You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@gump.apache.org by sebb <se...@gmail.com> on 2010/03/15 09:18:26 UTC
Re: svn commit: r923057 - /gump/metadata/project/commons-proper.xml
On 15/03/2010, bodewig@apache.org <bo...@apache.org> wrote:
> Author: bodewig
> Date: Mon Mar 15 05:23:18 2010
> New Revision: 923057
>
> URL: http://svn.apache.org/viewvc?rev=923057&view=rev
> Log:
> canonical property to skip tests in mvn
>
> Modified:
> gump/metadata/project/commons-proper.xml
>
> Modified: gump/metadata/project/commons-proper.xml
> URL: http://svn.apache.org/viewvc/gump/metadata/project/commons-proper.xml?rev=923057&r1=923056&r2=923057&view=diff
> ==============================================================================
> --- gump/metadata/project/commons-proper.xml (original)
> +++ gump/metadata/project/commons-proper.xml Mon Mar 15 05:23:18 2010
> @@ -449,7 +449,7 @@
> <description>Commons I/O Utility Package</description>
>
> <mvn basedir="io" goal="package">
> - <property name="skipTests" value="true"/>
> + <property name="maven.test.skip.exec" value="true"/>
maven.test.skip.exec is deprecated:
http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html#skipExec
which is why I used skipTests.
> </mvn>
>
> <option project="commons-lang-2.x" />
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r923057 - /gump/metadata/project/commons-proper.xml
Posted by Stefan Bodewig <bo...@apache.org>.
On 2010-03-15, sebb <se...@gmail.com> wrote:
> On 15/03/2010, Stefan Bodewig <bo...@apache.org> wrote:
>> On 2010-03-15, sebb <se...@gmail.com> wrote:
>>> On 15/03/2010, bodewig@apache.org <bo...@apache.org> wrote:
>>>> URL: http://svn.apache.org/viewvc?rev=923057&view=rev
>>>> Log:
>>>> canonical property to skip tests in mvn
>>>> - <property name="skipTests" value="true"/>
>>>>> <property name="maven.test.skip.exec" value="true"/>
>>> maven.test.skip.exec is deprecated:
>>> http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html#skipExec
>>> which is why I used skipTests.
>> I didn't know that and wanted things to be consistent - we use the now
>> deprecated version all over the place.
>> What is plugin version determined by? The installed mvn version (2.2 by
>> now) or the project's POM?
> The project POM determines the version, assuming that the POM defines
> the version.
>> skipTests would require Surefire 2.4 to work
>> and I don't know whether this is actually used by all projects.
> Good point, but Commons-parent 13 uses 2.5
I've reverted the commons-io project, if it works we can start moving
over other occurances of maven.test.skip.exec. It wouldn't be the first
mvn property that failed to work as advertised in the Gump context
(project.build.finalName is one such example) - it may be that we just
don't understand Maven well enough, though.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r923057 - /gump/metadata/project/commons-proper.xml
Posted by sebb <se...@gmail.com>.
On 15/03/2010, Stefan Bodewig <bo...@apache.org> wrote:
> On 2010-03-15, sebb <se...@gmail.com> wrote:
>
> > On 15/03/2010, bodewig@apache.org <bo...@apache.org> wrote:
>
>
> >> URL: http://svn.apache.org/viewvc?rev=923057&view=rev
> >> Log:
> >> canonical property to skip tests in mvn
>
>
> >> - <property name="skipTests" value="true"/>
> >> + <property name="maven.test.skip.exec" value="true"/>
>
> > maven.test.skip.exec is deprecated:
>
> > http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html#skipExec
>
> > which is why I used skipTests.
>
>
> I didn't know that and wanted things to be consistent - we use the now
> deprecated version all over the place.
>
> What is plugin version determined by? The installed mvn version (2.2 by
> now) or the project's POM?
The project POM determines the version, assuming that the POM defines
the version.
> skipTests would require Surefire 2.4 to work
> and I don't know whether this is actually used by all projects.
Good point, but Commons-parent 13 uses 2.5
Note that skipExec itself requires 2.3, so could cause problems if a
project uses an earlier version of surefire.
Only "skip" is valid for all versions of Surefire, but that is not ideal.
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> For additional commands, e-mail: general-help@gump.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: svn commit: r923057 - /gump/metadata/project/commons-proper.xml
Posted by Stefan Bodewig <bo...@apache.org>.
On 2010-03-15, sebb <se...@gmail.com> wrote:
> On 15/03/2010, bodewig@apache.org <bo...@apache.org> wrote:
>> URL: http://svn.apache.org/viewvc?rev=923057&view=rev
>> Log:
>> canonical property to skip tests in mvn
>> - <property name="skipTests" value="true"/>
>> + <property name="maven.test.skip.exec" value="true"/>
> maven.test.skip.exec is deprecated:
> http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html#skipExec
> which is why I used skipTests.
I didn't know that and wanted things to be consistent - we use the now
deprecated version all over the place.
What is plugin version determined by? The installed mvn version (2.2 by
now) or the project's POM? skipTests would require Surefire 2.4 to work
and I don't know whether this is actually used by all projects.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org