You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "tbw777 (via GitHub)" <gi...@apache.org> on 2023/02/13 22:40:55 UTC
[GitHub] [netbeans] tbw777 opened a new pull request, #5487: Removed a lot of compiler warnings
tbw777 opened a new pull request, #5487:
URL: https://github.com/apache/netbeans/pull/5487
Inserted diamond in constructions like this:
ArrayList<Strings> = new ArrayList();
No any interfaces was changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5487: Removed a lot of compiler warnings
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5487:
URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1430247741
> Another good reason to keep these type of PRs smaller in size.
Fully agree.
These huge PRs that change many files are prone to give problems. We should balance the benefits and the risks of these PRs.
And don't worry, @BradWalker ! This is something that could happen to anyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5487: Removed a lot of compiler warnings
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5487:
URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1430797489
> And don't worry, @BradWalker ! This is something that could happen to anyone!
@vieiro @BradWalker yes! This happens sometimes, so please don't worry about it. Its just that if you would have waited with the merge 1-2 days after review, I am certain someone would have noticed.
why?
because I for example try to look at https://github.com/apache/netbeans/actions on a daily basis to check if there is something to play whack-a-mole with, that is also how I noticed this in the first place. When someone syncs a new or old PR I would notice this too (since it appears on the all-knowing list) and probably check if its properly labeled. IMO the main lesson learned here should be to not rush PRs in, even if they seem trivial and were carefully reviewed.
This could have happened with a small PR too which only covers one module or less - it likely would have required some of the [[ci] labels](https://github.com/apache/netbeans/labels?q=%5Bci%5D) too. Java PRs need Java, PHP needs PHP otherwise the correct tests won't run etc etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5487: Removed a lot of compiler warnings
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5487:
URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1429891166
the changes itself were fine, the problem was that some were in test data. Just don't be so quick with the merge button next time. It is perfectly fine to let a PR sit a few days - increases the probability that someone notices things like this, e.g missing label to run all tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker merged pull request #5487: Removed a lot of compiler warnings
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker merged PR #5487:
URL: https://github.com/apache/netbeans/pull/5487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5487: Removed a lot of compiler warnings
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #5487:
URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1429921129
> the changes itself were fine, the problem was that some were in test data. Just don't be so quick with the merge button next time. It is perfectly fine to let a PR sit a few days - increases the probability that someone notices things like this, e.g missing label to run all tests.
Agreed.
I looked at each change. But, making a change in test code is definitely a danger.
Another good reason to keep these type of PRs smaller in size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5487: Removed a lot of compiler warnings
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5487:
URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1429822160
please don't ever merge PRs which don't have tests run on them! This PR broke master. There is no need to hurry.
This is a project wide cleanup which requires all tests to be run which is activated with the `ci:all-tests` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5487: Removed a lot of compiler warnings
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5487:
URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1430807423
also regarding large cleanup PRs in general:
in my book they are fine as long they remain reviewable (of course the PR itself should have a purpose too - I am not saying that every possible automated cleanup is worth the review time or to be integrated). It helps a lot to split large PRs into commits - if someone would only have the time to review one commit, thats fine - add a comment to tell the next reviewer.
We can't split everything into PRs otherwise every project wide cleanup would mean 18 PRs, one for each cluster - lets not do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on pull request #5487: Removed a lot of compiler warnings
Posted by "BradWalker (via GitHub)" <gi...@apache.org>.
BradWalker commented on PR #5487:
URL: https://github.com/apache/netbeans/pull/5487#issuecomment-1429879655
> please don't ever merge PRs which don't have tests run on them! This PR broke master. There is no need to hurry.
>
> This is a project wide cleanup which requires all tests to be run which is activated with the `ci:all-tests` label.
As someone who has previously worked on things in this area, I spent the time to look at each file that was changed. So I'll accept the responsibility for what happened. It appeared to me that the tests were being "skipped" by design. Previously when I've looked at the test runs, the system always showed as "failed". So it was clearly my mistake.
My apologies to everyone! I'll be more diligent next time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists