[GitHub] [tvm] ganler commented on pull request #12337: Update C++ standard to C++17

[GitBox <gi...@apache.org>]

ganler commented on PR #12337:
URL: https://github.com/apache/tvm/pull/12337#issuecomment-1208754354

   Great news!
   
   Just need to carefully update the installation documents as well. For example, update "C++ 14" to "C++ 17" in https://github.com/apache/tvm/blob/fbb7b5d1a0d82acb1f581dd2ec362b4dcad2638e/docs/install/from_source.rst
   
   In the meantime, it might be better to specify the required minimal compiler [versions](https://en.cppreference.com/w/cpp/compiler_support/17) as the coverage to C++17 standard can be quite different in different compiler versions.
   
   For example, if we just want to pass the "-std=c++17" flag, then the required minimals can be:
   
   - gcc >= 5
   - clang >= 5
   - visual studio >= 2017 15.3
   
   However, those initial version might badly support some popular library features like `std::filesystem`. For example, gcc implements filesystems as a non-experimental library in [gcc-8](https://gcc.gnu.org/gcc-8/changes.html).
   
   We may reference how other open-source projects moves to C++17. For example, [LLVM](https://discourse.llvm.org/t/important-new-toolchain-requirements-to-build-llvm-will-most-likely-be-landing-within-a-week-prepare-your-buildbots/61447) enables C++17 on Aprl 8 this year with several compiler version [constraints](https://github.com/llvm/llvm-project/commit/4c72deb613d9d8838785b431facb3eb480fb2f51).
   
   cc: @junrushao1994 @tqchen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org