[GitHub] [sling-org-apache-sling-extensions-webconsolesecurityprovider] cziegeler commented on a diff in pull request #2: SLING-11503 option to authenticate webconsole only against JCR

[GitBox <gi...@apache.org>]

cziegeler commented on code in PR #2:
URL: https://github.com/apache/sling-org-apache-sling-extensions-webconsolesecurityprovider/pull/2#discussion_r933817016


##########
src/main/java/org/apache/sling/extensions/webconsolesecurityprovider/internal/ServicesListener.java:
##########
@@ -41,6 +41,8 @@ public class ServicesListener {
     private static final String AUTH_SUPPORT_CLASS = "org.apache.sling.auth.core.AuthenticationSupport";
     private static final String AUTHENTICATOR_CLASS = "org.apache.sling.api.auth.Authenticator";
     private static final String REPO_CLASS = "javax.jcr.Repository";
+    
+    public static final String WEBCONSOLE_FORCE_AUTH_AGAINST_JCR = "webconsole.forceJCRAuthentication";

Review Comment:
   I think its good if the name is prefixed with "sling"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org