Re: svn commit: r23366 - trunk/subversion/libsvn_subr

[Malcolm Rowe <ma...@farside.org.uk>]

On Wed, Feb 07, 2007 at 09:41:05AM -0800, cmpilato@tigris.org wrote:
> * subversion/libsvn_subr/path.c
>   (svn_path_splitext): Rename variable 'last_period' to 'last_dot'.
>     No logic changes.
> 

The comments all still say 'period'.  What was the rationale behind
this, by the way?

Regards,
Malcolm

Re: svn commit: r23366 - trunk/subversion/libsvn_subr

["C. Michael Pilato" <cm...@collab.net>]

Malcolm Rowe wrote:
> On Wed, Feb 07, 2007 at 09:41:05AM -0800, cmpilato@tigris.org wrote:
>> * subversion/libsvn_subr/path.c
>>   (svn_path_splitext): Rename variable 'last_period' to 'last_dot'.
>>     No logic changes.
>>
> 
> The comments all still say 'period'.  

Yeah.  Doesn't bother me so much.

> What was the rationale behind this, by the way?

Code churn?

Seriously, the "_period" naming had been bugging me anyway because my mind
kept associating "last period" with the final third of a hockey game or
something, and using a shorter name allowed me to not have to line-wrap a
bit of arithmetic.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand