[GitHub] [accumulo] drewfarris commented on a change in pull request #1060: Closes #1053 add multi-volume support to import table command.

[GitBox <gi...@apache.org>]

drewfarris commented on a change in pull request #1060: Closes #1053 add multi-volume support to import table command.
URL: https://github.com/apache/accumulo/pull/1060#discussion_r274899435
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/tableOps/tableImport/PopulateMetadataTable.java
 ##########
 @@ -87,110 +86,112 @@
   @Override
   public Repo<Master> call(long tid, Master master) throws Exception {
 
-    Path path = new Path(tableInfo.exportDir, Constants.EXPORT_FILE);
+    Path path = new Path(tableInfo.exportFile);
 
     BatchWriter mbw = null;
     ZipInputStream zis = null;
 
     try {
       VolumeManager fs = master.getFileSystem();
+      final String[] volumes = ServerConstants.getBaseUris(master.getContext());
 
       mbw = master.getContext().createBatchWriter(MetadataTable.NAME, new BatchWriterConfig());
 
       zis = new ZipInputStream(fs.open(path));
 
 Review comment:
   There is one export file, and thus one `EXPORT_METADATA_FILE` despite the number of `tableInfo.directories`. It is expected that the sets of rfiles referenced in both places is congruent, but we could positively check that this is the case in this code.
   
   I'm definitely missing some code here. We iterate over the original metadata table entries, I haven't tracked which member from `tableInfo.directories` each original file was found in and thus end up failing the `exists` check in `MoveExportedFiles`. I need to go back to the drawing board here and change things a bit so that information can be included in the `fileNameMappings` structure.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services