You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/04 14:39:29 UTC

[GitHub] [trafficcontrol] zrhoffman opened a new pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

zrhoffman opened a new pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498


   <!--
   ************ STOP!! ************
   If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
   the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
   -->
   ## What does this PR (Pull Request) do?
   <!-- Explain the changes you made here. If this fixes an Issue, identify it by
   replacing the text in the checkbox item with the Issue number e.g.
   
   - [x] This PR fixes #9001 OR is not related to any Issue
   
   ^ This will automatically close Issue number 9001 when the Pull Request is
   merged (The '#' is important).
   
   Be sure you check the box properly, see the "The following criteria are ALL
   met by this PR" section for details.
   -->
   
   As a follow-up to #5229, this PR
   - Adds a GitHub Actions workflow to verify that `go.mod`, `go.sum`, and the `vendor` directory have no uncommitted Git changes when modules are vendored.
   - Removes an unused dependency and updates `go.sum`
   - Gets `go mod vendor` to run successfully in the CiaB Traffic Ops `integration` service's Dockerfile by including the `v4-client` directory. Error from `go mod vendor` that is fixed:
     ```go
     #29 28.09 github.com/apache/trafficcontrol/traffic_ops/testing/api/v4 tested by
     #29 28.09       github.com/apache/trafficcontrol/traffic_ops/testing/api/v4.test imports
     #29 28.09       github.com/apache/trafficcontrol/traffic_ops/v4-client: no matching versions for query "latest"
     ```
   - Gets the Dockerized TO and TM unit tests to working again by including go.mod/go.sum in the Docker image.
   - [x] is not related to any Issue<!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this
   Pull Request. Also, feel free to add the name of a tool or script that is
   affected but not on the list.
   
   Additionally, if this Pull Request does NOT affect documentation, please
   explain why documentation is not required. -->
   
   - CDN in a Box
   - CI tests
   
   ## What is the best way to verify this PR?
   <!-- Please include here ALL the steps necessary to test your Pull Request. If
   it includes tests (and most should), outline here the steps needed to run the
   tests. If not, lay out the manual testing procedure and please explain why
   tests are unnecessary for this Pull Request. -->
   * Verify the GitHub Action is working as intended.
     - Check the result of the *Check Go modules* workflow at 0e54b997ff. The following steps are expected to have failed:
       * Untracked changes to vendored dependencies
       * Changes to go.sum
   
     - Check the result of the *Check Go modules* workflow at fb9f772b25. It is expected to succeed.
   
   * Run the TO API tests in CDN in a Box. On my computer, it took 55 minutes from the time when the API tests started running.
     ```shell
     docker-compose -f docker-compose.yml -f docker-compose.traffic-ops-test.yml up --no-deps -d edge dns db smtp trafficops-perl trafficops trafficvault integration;
     docker-compose -f docker-compose.traffic-ops-test.yml logs -f integration;
     ```
   
   * Run the Traffic Monitor unit tests in Docker
     ```shell
     docker-compose -f traffic_monitor/tests/docker-compose.yml up --build
     ```
   
   * Run the Traffic Ops unit tests in Docker
     ```shell
     docker-compose -f traffic_ops/app/bin/tests/docker-compose.yml up --build
     ```
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   <!-- If this PR fixes a bug, please list here all of the affected versions - to
   the best of your knowledge. It's also pretty helpful to include a commit hash
   of where 'master' is at the time this PR is opened (if it affects master),
   because what 'master' means will change over time. For example, if this PR
   fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
   and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
   look like:
   
   - master (1df853c8)
   - 4.0.0
   - 4.0.1 (RC1)
   
   If you don't know what other versions might have this bug, AND don't know how
   to find the commit hash of 'master', then feel free to leave this section
   blank (or, preferably, delete it entirely).
    -->
   - master (09e25013fd)
   
   ## The following criteria are ALL met by this PR
   <!-- Check the boxes to signify that the associated statement is true. To
   "check a box", replace the space inside of the square brackets with an 'x'.
   e.g.
   
   - [ x] <- Wrong
   - [x ] <- Wrong
   - [] <- Wrong
   - [*] <- Wrong
   - [x] <- Correct!
   
   -->
   
   - [x] This PR includes tests
   - [x] This PR includes documentation
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498#discussion_r570397986



##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -91,6 +95,9 @@ COPY --from=integration-builder \
 COPY --from=integration-builder \
     /go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api/traffic_ops_v3_integration_test \
     /opt/integration/app/
+COPY --from=integration-builder \

Review comment:
       Consolidated them to a single cache layer in 6c3507ac8c.

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -47,6 +47,7 @@ COPY ./lib/ /go/src/github.com/apache/trafficcontrol/lib/
 COPY ./traffic_ops/v1-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v1-client/
 COPY ./traffic_ops/v2-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v2-client/
 COPY ./traffic_ops/v3-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v3-client/
+COPY ./traffic_ops/v4-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v4-client/
 COPY ./traffic_ops/client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/client/

Review comment:
       No longer copying the symlink in d23aea283b.

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -56,9 +57,11 @@ COPY ./go.mod ./go.sum /go/src/github.com/apache/trafficcontrol/
 WORKDIR /go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api
 RUN go mod vendor -v
 
-RUN CGO_ENABLED=0 go test -c ./v1* -ldflags="-w -s" -o traffic_ops_v1_integration_test
-RUN CGO_ENABLED=0 go test -c ./v2* -ldflags="-w -s" -o traffic_ops_v2_integration_test
-RUN CGO_ENABLED=0 go test -c ./v3* -ldflags="-w -s" -o traffic_ops_v3_integration_test
+ENV CGO_ENABLED=0
+RUN go test -c ./v1 -ldflags="-w -s" -o traffic_ops_v1_integration_test
+RUN go test -c ./v2 -ldflags="-w -s" -o traffic_ops_v2_integration_test
+RUN go test -c ./v3 -ldflags="-w -s" -o traffic_ops_v3_integration_test
+RUN go test -c ./v4 -ldflags="-w -s" -o traffic_ops_v4_integration_test

Review comment:
       Made it a single cache layer in 99c1b1af37




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498#discussion_r570396176



##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -82,6 +85,7 @@ COPY ./infrastructure/cdn-in-a-box/traffic_ops_integration_test/config.sh /opt/i
 COPY ./traffic_ops/testing/api/v1/tc-fixtures.json /opt/integration/app/tc-fixtures-v1.json
 COPY ./traffic_ops/testing/api/v2/tc-fixtures.json /opt/integration/app/tc-fixtures-v2.json
 COPY ./traffic_ops/testing/api/v3/tc-fixtures.json /opt/integration/app/tc-fixtures-v3.json
+COPY ./traffic_ops/testing/api/v4/tc-fixtures.json /opt/integration/app/tc-fixtures-v4.json

Review comment:
       It doesn't just copy the files, it gives each of them a new name. I'm not sure how to make that a single cache layer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498#discussion_r570480624



##########
File path: infrastructure/cdn-in-a-box/enroller/enroller.go
##########
@@ -33,7 +33,7 @@ import (
 
 	log "github.com/apache/trafficcontrol/lib/go-log"
 	tc "github.com/apache/trafficcontrol/lib/go-tc"
-	"github.com/apache/trafficcontrol/traffic_ops/client"
+	"github.com/apache/trafficcontrol/traffic_ops/v4-client"

Review comment:
       I believe this line is causing the build failure:
   ```
   2021-02-04T18:51:49.1234730Z #16 17.29 ./enroller.go:680:29: toSession.CreateServerWithHdr undefined (type *session has no field or method CreateServerWithHdr)
   ```
   The fix would be to link the enroller against the "stable" API client - v3 - or to update references to `CreateServerWithHdr` to simply `CreateServer` (as there is no version in v4 that doesn't use a header).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498#discussion_r570396176



##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -82,6 +85,7 @@ COPY ./infrastructure/cdn-in-a-box/traffic_ops_integration_test/config.sh /opt/i
 COPY ./traffic_ops/testing/api/v1/tc-fixtures.json /opt/integration/app/tc-fixtures-v1.json
 COPY ./traffic_ops/testing/api/v2/tc-fixtures.json /opt/integration/app/tc-fixtures-v2.json
 COPY ./traffic_ops/testing/api/v3/tc-fixtures.json /opt/integration/app/tc-fixtures-v3.json
+COPY ./traffic_ops/testing/api/v4/tc-fixtures.json /opt/integration/app/tc-fixtures-v4.json

Review comment:
       It doesn't just copy the files, it gives each of them a new name. I'm not sure how to make that a single cache layer.

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -91,6 +95,9 @@ COPY --from=integration-builder \
 COPY --from=integration-builder \
     /go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api/traffic_ops_v3_integration_test \
     /opt/integration/app/
+COPY --from=integration-builder \

Review comment:
       Consolidated them to a single cache layer in 6c3507ac8c.

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -47,6 +47,7 @@ COPY ./lib/ /go/src/github.com/apache/trafficcontrol/lib/
 COPY ./traffic_ops/v1-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v1-client/
 COPY ./traffic_ops/v2-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v2-client/
 COPY ./traffic_ops/v3-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v3-client/
+COPY ./traffic_ops/v4-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v4-client/
 COPY ./traffic_ops/client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/client/

Review comment:
       No longer copying the symlink in d23aea283b.

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -56,9 +57,11 @@ COPY ./go.mod ./go.sum /go/src/github.com/apache/trafficcontrol/
 WORKDIR /go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api
 RUN go mod vendor -v
 
-RUN CGO_ENABLED=0 go test -c ./v1* -ldflags="-w -s" -o traffic_ops_v1_integration_test
-RUN CGO_ENABLED=0 go test -c ./v2* -ldflags="-w -s" -o traffic_ops_v2_integration_test
-RUN CGO_ENABLED=0 go test -c ./v3* -ldflags="-w -s" -o traffic_ops_v3_integration_test
+ENV CGO_ENABLED=0
+RUN go test -c ./v1 -ldflags="-w -s" -o traffic_ops_v1_integration_test
+RUN go test -c ./v2 -ldflags="-w -s" -o traffic_ops_v2_integration_test
+RUN go test -c ./v3 -ldflags="-w -s" -o traffic_ops_v3_integration_test
+RUN go test -c ./v4 -ldflags="-w -s" -o traffic_ops_v4_integration_test

Review comment:
       Made it a single cache layer in 99c1b1af37

##########
File path: infrastructure/cdn-in-a-box/enroller/enroller.go
##########
@@ -33,7 +33,7 @@ import (
 
 	log "github.com/apache/trafficcontrol/lib/go-log"
 	tc "github.com/apache/trafficcontrol/lib/go-tc"
-	"github.com/apache/trafficcontrol/traffic_ops/client"
+	"github.com/apache/trafficcontrol/traffic_ops/v4-client"

Review comment:
       Using `CreateServer()` in 97ea08c368.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498#discussion_r570494904



##########
File path: infrastructure/cdn-in-a-box/enroller/enroller.go
##########
@@ -33,7 +33,7 @@ import (
 
 	log "github.com/apache/trafficcontrol/lib/go-log"
 	tc "github.com/apache/trafficcontrol/lib/go-tc"
-	"github.com/apache/trafficcontrol/traffic_ops/client"
+	"github.com/apache/trafficcontrol/traffic_ops/v4-client"

Review comment:
       Using `CreateServer()` in 97ea08c368.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498#discussion_r570381565



##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -47,6 +47,7 @@ COPY ./lib/ /go/src/github.com/apache/trafficcontrol/lib/
 COPY ./traffic_ops/v1-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v1-client/
 COPY ./traffic_ops/v2-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v2-client/
 COPY ./traffic_ops/v3-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v3-client/
+COPY ./traffic_ops/v4-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v4-client/
 COPY ./traffic_ops/client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/client/

Review comment:
       Copying in this symlink feels extraneous

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -91,6 +95,9 @@ COPY --from=integration-builder \
 COPY --from=integration-builder \
     /go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api/traffic_ops_v3_integration_test \
     /opt/integration/app/
+COPY --from=integration-builder \

Review comment:
       Can these `COPY --from=integration-builder`s be a single cache layer?

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -56,9 +57,11 @@ COPY ./go.mod ./go.sum /go/src/github.com/apache/trafficcontrol/
 WORKDIR /go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api
 RUN go mod vendor -v
 
-RUN CGO_ENABLED=0 go test -c ./v1* -ldflags="-w -s" -o traffic_ops_v1_integration_test
-RUN CGO_ENABLED=0 go test -c ./v2* -ldflags="-w -s" -o traffic_ops_v2_integration_test
-RUN CGO_ENABLED=0 go test -c ./v3* -ldflags="-w -s" -o traffic_ops_v3_integration_test
+ENV CGO_ENABLED=0
+RUN go test -c ./v1 -ldflags="-w -s" -o traffic_ops_v1_integration_test
+RUN go test -c ./v2 -ldflags="-w -s" -o traffic_ops_v2_integration_test
+RUN go test -c ./v3 -ldflags="-w -s" -o traffic_ops_v3_integration_test
+RUN go test -c ./v4 -ldflags="-w -s" -o traffic_ops_v4_integration_test

Review comment:
       Can these be a single cache layer?

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -82,6 +85,7 @@ COPY ./infrastructure/cdn-in-a-box/traffic_ops_integration_test/config.sh /opt/i
 COPY ./traffic_ops/testing/api/v1/tc-fixtures.json /opt/integration/app/tc-fixtures-v1.json
 COPY ./traffic_ops/testing/api/v2/tc-fixtures.json /opt/integration/app/tc-fixtures-v2.json
 COPY ./traffic_ops/testing/api/v3/tc-fixtures.json /opt/integration/app/tc-fixtures-v3.json
+COPY ./traffic_ops/testing/api/v4/tc-fixtures.json /opt/integration/app/tc-fixtures-v4.json

Review comment:
       I'm pretty sure these four copies can be a single cache layer

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -82,6 +85,7 @@ COPY ./infrastructure/cdn-in-a-box/traffic_ops_integration_test/config.sh /opt/i
 COPY ./traffic_ops/testing/api/v1/tc-fixtures.json /opt/integration/app/tc-fixtures-v1.json
 COPY ./traffic_ops/testing/api/v2/tc-fixtures.json /opt/integration/app/tc-fixtures-v2.json
 COPY ./traffic_ops/testing/api/v3/tc-fixtures.json /opt/integration/app/tc-fixtures-v3.json
+COPY ./traffic_ops/testing/api/v4/tc-fixtures.json /opt/integration/app/tc-fixtures-v4.json

Review comment:
       Oh, so it does.

##########
File path: infrastructure/cdn-in-a-box/enroller/enroller.go
##########
@@ -33,7 +33,7 @@ import (
 
 	log "github.com/apache/trafficcontrol/lib/go-log"
 	tc "github.com/apache/trafficcontrol/lib/go-tc"
-	"github.com/apache/trafficcontrol/traffic_ops/client"
+	"github.com/apache/trafficcontrol/traffic_ops/v4-client"

Review comment:
       I believe this line is causing the build failure:
   ```
   2021-02-04T18:51:49.1234730Z #16 17.29 ./enroller.go:680:29: toSession.CreateServerWithHdr undefined (type *session has no field or method CreateServerWithHdr)
   ```
   The fix would be to link the enroller against the "stable" API client - v3 - or to update references to `CreateServerWithHdr` to simply `CreateServer` (as there is no version in v4 that doesn't use a header).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498#discussion_r570381565



##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -47,6 +47,7 @@ COPY ./lib/ /go/src/github.com/apache/trafficcontrol/lib/
 COPY ./traffic_ops/v1-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v1-client/
 COPY ./traffic_ops/v2-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v2-client/
 COPY ./traffic_ops/v3-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v3-client/
+COPY ./traffic_ops/v4-client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/v4-client/
 COPY ./traffic_ops/client/ /go/src/github.com/apache/trafficcontrol/traffic_ops/client/

Review comment:
       Copying in this symlink feels extraneous

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -91,6 +95,9 @@ COPY --from=integration-builder \
 COPY --from=integration-builder \
     /go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api/traffic_ops_v3_integration_test \
     /opt/integration/app/
+COPY --from=integration-builder \

Review comment:
       Can these `COPY --from=integration-builder`s be a single cache layer?

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -56,9 +57,11 @@ COPY ./go.mod ./go.sum /go/src/github.com/apache/trafficcontrol/
 WORKDIR /go/src/github.com/apache/trafficcontrol/traffic_ops/testing/api
 RUN go mod vendor -v
 
-RUN CGO_ENABLED=0 go test -c ./v1* -ldflags="-w -s" -o traffic_ops_v1_integration_test
-RUN CGO_ENABLED=0 go test -c ./v2* -ldflags="-w -s" -o traffic_ops_v2_integration_test
-RUN CGO_ENABLED=0 go test -c ./v3* -ldflags="-w -s" -o traffic_ops_v3_integration_test
+ENV CGO_ENABLED=0
+RUN go test -c ./v1 -ldflags="-w -s" -o traffic_ops_v1_integration_test
+RUN go test -c ./v2 -ldflags="-w -s" -o traffic_ops_v2_integration_test
+RUN go test -c ./v3 -ldflags="-w -s" -o traffic_ops_v3_integration_test
+RUN go test -c ./v4 -ldflags="-w -s" -o traffic_ops_v4_integration_test

Review comment:
       Can these be a single cache layer?

##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -82,6 +85,7 @@ COPY ./infrastructure/cdn-in-a-box/traffic_ops_integration_test/config.sh /opt/i
 COPY ./traffic_ops/testing/api/v1/tc-fixtures.json /opt/integration/app/tc-fixtures-v1.json
 COPY ./traffic_ops/testing/api/v2/tc-fixtures.json /opt/integration/app/tc-fixtures-v2.json
 COPY ./traffic_ops/testing/api/v3/tc-fixtures.json /opt/integration/app/tc-fixtures-v3.json
+COPY ./traffic_ops/testing/api/v4/tc-fixtures.json /opt/integration/app/tc-fixtures-v4.json

Review comment:
       I'm pretty sure these four copies can be a single cache layer




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 merged pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 merged pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5498: GitHub Actions workflow to validate go.mod, go.sum, and vendor directory

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #5498:
URL: https://github.com/apache/trafficcontrol/pull/5498#discussion_r570400737



##########
File path: infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile
##########
@@ -82,6 +85,7 @@ COPY ./infrastructure/cdn-in-a-box/traffic_ops_integration_test/config.sh /opt/i
 COPY ./traffic_ops/testing/api/v1/tc-fixtures.json /opt/integration/app/tc-fixtures-v1.json
 COPY ./traffic_ops/testing/api/v2/tc-fixtures.json /opt/integration/app/tc-fixtures-v2.json
 COPY ./traffic_ops/testing/api/v3/tc-fixtures.json /opt/integration/app/tc-fixtures-v3.json
+COPY ./traffic_ops/testing/api/v4/tc-fixtures.json /opt/integration/app/tc-fixtures-v4.json

Review comment:
       Oh, so it does.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org