You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Avery Ching <av...@gmail.com> on 2012/10/23 03:03:11 UTC
Review Request: GIRAPH-384: Remove duplicate BspCase in
giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7702/
-----------------------------------------------------------
Review request for giraph.
Description
-------
giraph-formats-contrib can now use the giraph test jar instead of duplicating code.
This addresses bug GIRAPH-384.
https://issues.apache.org/jira/browse/GIRAPH-384
Diffs
-----
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml 1401120
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/BspCase.java 1401120
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/accumulo/TestAccumuloVertexFormat.java 1401120
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hbase/TestHBaseRootMarkerVertextFormat.java 1401120
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hcatalog/TestHiveUtils.java 1401120
Diff: https://reviews.apache.org/r/7702/diff/
Testing
-------
mvn clean install
Thanks,
Avery Ching
Re: Review Request: GIRAPH-384: Remove duplicate BspCase in
giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Posted by Nitay Joffe <ni...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7702/#review12674
-----------------------------------------------------------
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml
<https://reviews.apache.org/r/7702/#comment27028>
move this to top level pom, use ${project.version}
http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/accumulo/TestAccumuloVertexFormat.java
<https://reviews.apache.org/r/7702/#comment27029>
Why not getClass()?
- Nitay Joffe
On Oct. 23, 2012, 1:03 a.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7702/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2012, 1:03 a.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> giraph-formats-contrib can now use the giraph test jar instead of duplicating code.
>
>
> This addresses bug GIRAPH-384.
> https://issues.apache.org/jira/browse/GIRAPH-384
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml 1401120
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/BspCase.java 1401120
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/accumulo/TestAccumuloVertexFormat.java 1401120
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hbase/TestHBaseRootMarkerVertextFormat.java 1401120
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hcatalog/TestHiveUtils.java 1401120
>
> Diff: https://reviews.apache.org/r/7702/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Avery Ching
>
>
Re: Review Request: GIRAPH-384: Remove duplicate BspCase in
giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Posted by Brian Femiano <bf...@gmail.com>.
Thanks Avery. This has been on my todo list for awhile.
On Mon, Oct 22, 2012 at 9:03 PM, Avery Ching <av...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7702/
> -----------------------------------------------------------
>
> Review request for giraph.
>
>
> Description
> -------
>
> giraph-formats-contrib can now use the giraph test jar instead of
> duplicating code.
>
>
> This addresses bug GIRAPH-384.
> https://issues.apache.org/jira/browse/GIRAPH-384
>
>
> Diffs
> -----
>
>
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/pom.xml1401120
>
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/BspCase.java1401120
>
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/accumulo/TestAccumuloVertexFormat.java1401120
>
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hbase/TestHBaseRootMarkerVertextFormat.java1401120
>
> http://svn.apache.org/repos/asf/giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hcatalog/TestHiveUtils.java1401120
>
> Diff: https://reviews.apache.org/r/7702/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Avery Ching
>
>