[GitHub] [incubator-streampipes-extensions] bossenti commented on a change in pull request #43: [STREAMPIPES-343] Added timeinterval between the two events

[GitBox <gi...@apache.org>]

bossenti commented on a change in pull request #43:
URL: https://github.com/apache/incubator-streampipes-extensions/pull/43#discussion_r627508588



##########
File path: streampipes-connect-adapters/src/main/java/org/apache/streampipes/connect/protocol/set/FileProtocol.java
##########
@@ -79,11 +84,32 @@ public ProtocolDescription declareModel() {
     @Override
     public Protocol getInstance(ProtocolDescription protocolDescription, Parser parser, Format format) {
         StaticPropertyExtractor extractor = StaticPropertyExtractor.from(protocolDescription.getConfig());
-
+        this.timeBetweenReplay = extractor.singleValueParameter(INTERVAL_KEY, Integer.class);

Review comment:
       ```suggestion
           int timeBetweenReplay = extractor.singleValueParameter(INTERVAL_KEY, Integer.class);
   ```

##########
File path: streampipes-connect-adapters/src/main/java/org/apache/streampipes/connect/protocol/set/FileProtocol.java
##########
@@ -79,11 +84,32 @@ public ProtocolDescription declareModel() {
     @Override
     public Protocol getInstance(ProtocolDescription protocolDescription, Parser parser, Format format) {
         StaticPropertyExtractor extractor = StaticPropertyExtractor.from(protocolDescription.getConfig());
-
+        this.timeBetweenReplay = extractor.singleValueParameter(INTERVAL_KEY, Integer.class);
         String fileFetchUrl = extractor.selectedFileFetchUrl("filePath");
         return new FileProtocol(parser, format, fileFetchUrl);

Review comment:
       ```suggestion
           return new FileProtocol(parser, format, fileFetchUrl, timeBetweenReplay);
   ```
   Please adapt the constructor accordingly




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org