You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/10 06:05:27 UTC
[GitHub] [flink] twalthr commented on a change in pull request #9049:
[FLINK-13176][SQL CLI] remember current catalog and database in SQL CLI
SessionContext
twalthr commented on a change in pull request #9049: [FLINK-13176][SQL CLI] remember current catalog and database in SQL CLI SessionContext
URL: https://github.com/apache/flink/pull/9049#discussion_r301898115
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/SessionContext.java
##########
@@ -40,6 +44,9 @@
private final Map<String, ViewEntry> views;
+ private Optional<String> currentCatalog = Optional.empty();
Review comment:
Could we just put the current catalog and into the `sessionProperties`? Then handling of merging environment files would happen automatically and we could reduce the amount of changes in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services