You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/09/12 04:21:01 UTC
[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4378
Change subject: KUDU-1604 - [python] Fix bug getting table column by index
......................................................................
KUDU-1604 - [python] Fix bug getting table column by index
There is currently a bug when attempting to access a table column
by its index. When attempted, the column definition returned has
the index value as the column name. This patch fixes this bug so
that the appropriate column name is set and returned. An existing
test has been updated to account for this usage.
Change-Id: If754ddb463223430c7fe3c8920e433031162562e
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 11 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/4378/1
--
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1604 - [python] Fix bug getting table column by index
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3363/
--
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4378
to look at the new patch set (#2).
Change subject: KUDU-1604 - [python] Fix bug getting table column by index
......................................................................
KUDU-1604 - [python] Fix bug getting table column by index
There is currently a bug when attempting to access a table column
by its index. When attempted, the column definition returned has
the index value as the column name. This patch fixes this bug so
that the appropriate column name is set and returned. An existing
test has been updated to account for this usage.
Change-Id: If754ddb463223430c7fe3c8920e433031162562e
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 13 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/4378/2
--
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: KUDU-1604 - [python] Fix bug getting table column by index
......................................................................
KUDU-1604 - [python] Fix bug getting table column by index
There is currently a bug when attempting to access a table column
by its index. When attempted, the column definition returned has
the index value as the column name. This patch fixes this bug so
that the appropriate column name is set and returned. An existing
test has been updated to account for this usage.
Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Reviewed-on: http://gerrit.cloudera.org:8080/4378
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
---
M python/kudu/client.pyx
M python/kudu/tests/test_client.py
2 files changed, 13 insertions(+), 10 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1604 - [python] Fix bug getting table column by index
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4378/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
Line 38: cols = [table['key'], table[0]]
since you're here, could you test getting another non-0 col?
--
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: KUDU-1604 - [python] Fix bug getting table column by index
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4378/1/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
Line 38: cols = [(table['key'], 'key', 'int32'),
> since you're here, could you test getting another non-0 col?
Changed to test a negative and a positive index
--
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-1604 - [python] Fix bug getting table column by index
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1604 - [python] Fix bug getting table column by index
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-1604 - [python] Fix bug getting table column by index
......................................................................
Patch Set 2:
Build Started http://104.196.14.100/job/kudu-gerrit/3371/
--
To view, visit http://gerrit.cloudera.org:8080/4378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If754ddb463223430c7fe3c8920e433031162562e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No