You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by lu...@apache.org on 2009/05/24 18:44:53 UTC
svn commit: r778191 - in /commons/proper/math/trunk/src:
java/org/apache/commons/math/linear/ java/org/apache/commons/math/ode/
test/org/apache/commons/math/linear/
test/org/apache/commons/math/linear/decomposition/
test/org/apache/commons/math/stat/re...
Author: luc
Date: Sun May 24 16:44:52 2009
New Revision: 778191
URL: http://svn.apache.org/viewvc?rev=778191&view=rev
Log:
removed Serializable from matrix visitors interfaces and classes
it doesn't make sense for these objects as they are intended to be transient
Modified:
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/AbstractFieldMatrix.java
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/AbstractRealMatrix.java
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultFieldMatrixChangingVisitor.java
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultFieldMatrixPreservingVisitor.java
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultRealMatrixChangingVisitor.java
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultRealMatrixPreservingVisitor.java
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/FieldMatrixChangingVisitor.java
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/FieldMatrixPreservingVisitor.java
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealMatrixChangingVisitor.java
commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealMatrixPreservingVisitor.java
commons/proper/math/trunk/src/java/org/apache/commons/math/ode/NordsieckTransformer.java
commons/proper/math/trunk/src/test/org/apache/commons/math/linear/DenseFieldMatrixTest.java
commons/proper/math/trunk/src/test/org/apache/commons/math/linear/DenseRealMatrixTest.java
commons/proper/math/trunk/src/test/org/apache/commons/math/linear/FieldMatrixImplTest.java
commons/proper/math/trunk/src/test/org/apache/commons/math/linear/RealMatrixImplTest.java
commons/proper/math/trunk/src/test/org/apache/commons/math/linear/decomposition/QRDecompositionImplTest.java
commons/proper/math/trunk/src/test/org/apache/commons/math/linear/decomposition/QRSolverTest.java
commons/proper/math/trunk/src/test/org/apache/commons/math/stat/regression/OLSMultipleLinearRegressionTest.java
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/AbstractFieldMatrix.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/AbstractFieldMatrix.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/AbstractFieldMatrix.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/AbstractFieldMatrix.java Sun May 24 16:44:52 2009
@@ -312,9 +312,6 @@
createMatrix(selectedRows.length, selectedColumns.length);
subMatrix.walkInOptimizedOrder(new DefaultFieldMatrixChangingVisitor<T>(field.getZero()) {
- /** Serializable version identifier. */
- private static final long serialVersionUID = 5079316658710707181L;
-
/** {@inheritDoc} */
@Override
public T visit(final int row, final int column, final T value) {
@@ -347,9 +344,6 @@
// copy entries
walkInOptimizedOrder(new DefaultFieldMatrixPreservingVisitor<T>(field.getZero()) {
- /** Serializable version identifier. */
- private static final long serialVersionUID = 1894428776156078725L;
-
/** Initial row index. */
private int startRow;
@@ -634,9 +628,6 @@
final FieldMatrix<T> out = createMatrix(nCols, nRows);
walkInOptimizedOrder(new DefaultFieldMatrixPreservingVisitor<T>(field.getZero()) {
- /** Serializable version identifier. */
- private static final long serialVersionUID = 6281961451465720534L;
-
/** {@inheritDoc} */
@Override
public void visit(final int row, final int column, final T value) {
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/AbstractRealMatrix.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/AbstractRealMatrix.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/AbstractRealMatrix.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/AbstractRealMatrix.java Sun May 24 16:44:52 2009
@@ -198,9 +198,6 @@
public double getNorm() {
return walkInColumnOrder(new RealMatrixPreservingVisitor() {
- /** Serializable version identifier */
- private static final long serialVersionUID = -2452270856202894168L;
-
/** Last row index. */
private double endRow;
@@ -240,9 +237,6 @@
public double getFrobeniusNorm() {
return walkInOptimizedOrder(new RealMatrixPreservingVisitor() {
- /** Serializable version identifier */
- private static final long serialVersionUID = -6065411033772300640L;
-
/** Sum of squared entries. */
private double sum;
@@ -297,9 +291,6 @@
createMatrix(selectedRows.length, selectedColumns.length);
subMatrix.walkInOptimizedOrder(new DefaultRealMatrixChangingVisitor() {
- /** Serializable version identifier. */
- private static final long serialVersionUID = 4572851009041214720L;
-
/** {@inheritDoc} */
@Override
public double visit(final int row, final int column, final double value) {
@@ -332,9 +323,6 @@
// copy entries
walkInOptimizedOrder(new DefaultRealMatrixPreservingVisitor() {
- /** Serializable version identifier. */
- private static final long serialVersionUID = -6302162622577015104L;
-
/** Initial row index. */
private int startRow;
@@ -621,9 +609,6 @@
final RealMatrix out = createMatrix(nCols, nRows);
walkInOptimizedOrder(new DefaultRealMatrixPreservingVisitor() {
- /** Serializable version identifier. */
- private static final long serialVersionUID = 2482589609486637597L;
-
/** {@inheritDoc} */
@Override
public void visit(final int row, final int column, final double value) {
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultFieldMatrixChangingVisitor.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultFieldMatrixChangingVisitor.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultFieldMatrixChangingVisitor.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultFieldMatrixChangingVisitor.java Sun May 24 16:44:52 2009
@@ -33,9 +33,6 @@
public class DefaultFieldMatrixChangingVisitor<T extends FieldElement<T>>
implements FieldMatrixChangingVisitor<T> {
- /** Serializable version identifier. */
- private static final long serialVersionUID = -7138694000397476118L;
-
/** Zero element of the field. */
private final T zero;
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultFieldMatrixPreservingVisitor.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultFieldMatrixPreservingVisitor.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultFieldMatrixPreservingVisitor.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultFieldMatrixPreservingVisitor.java Sun May 24 16:44:52 2009
@@ -33,9 +33,6 @@
public class DefaultFieldMatrixPreservingVisitor<T extends FieldElement<T>>
implements FieldMatrixPreservingVisitor<T> {
- /** Serializable version identifier. */
- private static final long serialVersionUID = 7998898965168636198L;
-
/** Zero element of the field. */
private final T zero;
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultRealMatrixChangingVisitor.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultRealMatrixChangingVisitor.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultRealMatrixChangingVisitor.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultRealMatrixChangingVisitor.java Sun May 24 16:44:52 2009
@@ -29,9 +29,6 @@
*/
public class DefaultRealMatrixChangingVisitor implements RealMatrixChangingVisitor {
- /** Serializable version identifier. */
- private static final long serialVersionUID = 892744666836410796L;
-
/** {@inheritDoc} */
public void start(int rows, int columns,
int startRow, int endRow, int startColumn, int endColumn) {
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultRealMatrixPreservingVisitor.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultRealMatrixPreservingVisitor.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultRealMatrixPreservingVisitor.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/DefaultRealMatrixPreservingVisitor.java Sun May 24 16:44:52 2009
@@ -29,9 +29,6 @@
*/
public class DefaultRealMatrixPreservingVisitor implements RealMatrixPreservingVisitor {
- /** Serializable version identifier. */
- private static final long serialVersionUID = -7608224814444142788L;
-
/** {@inheritDoc} */
public void start(int rows, int columns,
int startRow, int endRow, int startColumn, int endColumn) {
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/FieldMatrixChangingVisitor.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/FieldMatrixChangingVisitor.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/FieldMatrixChangingVisitor.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/FieldMatrixChangingVisitor.java Sun May 24 16:44:52 2009
@@ -17,8 +17,6 @@
package org.apache.commons.math.linear;
-import java.io.Serializable;
-
import org.apache.commons.math.FieldElement;
/**
@@ -28,7 +26,7 @@
* @version $Revision$ $Date$
* @since 2.0
*/
-public interface FieldMatrixChangingVisitor<T extends FieldElement<?>> extends Serializable {
+public interface FieldMatrixChangingVisitor<T extends FieldElement<?>> {
/**
* Start visiting a matrix.
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/FieldMatrixPreservingVisitor.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/FieldMatrixPreservingVisitor.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/FieldMatrixPreservingVisitor.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/FieldMatrixPreservingVisitor.java Sun May 24 16:44:52 2009
@@ -17,8 +17,6 @@
package org.apache.commons.math.linear;
-import java.io.Serializable;
-
import org.apache.commons.math.FieldElement;
/**
@@ -28,7 +26,7 @@
* @version $Revision$ $Date$
* @since 2.0
*/
-public interface FieldMatrixPreservingVisitor<T extends FieldElement<?>> extends Serializable {
+public interface FieldMatrixPreservingVisitor<T extends FieldElement<?>> {
/**
* Start visiting a matrix.
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealMatrixChangingVisitor.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealMatrixChangingVisitor.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealMatrixChangingVisitor.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealMatrixChangingVisitor.java Sun May 24 16:44:52 2009
@@ -17,8 +17,6 @@
package org.apache.commons.math.linear;
-import java.io.Serializable;
-
/**
* Interface defining a visitor for matrix entries.
*
@@ -26,7 +24,7 @@
* @version $Revision$ $Date$
* @since 2.0
*/
-public interface RealMatrixChangingVisitor extends Serializable {
+public interface RealMatrixChangingVisitor {
/**
* Start visiting a matrix.
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealMatrixPreservingVisitor.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealMatrixPreservingVisitor.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealMatrixPreservingVisitor.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/linear/RealMatrixPreservingVisitor.java Sun May 24 16:44:52 2009
@@ -17,8 +17,6 @@
package org.apache.commons.math.linear;
-import java.io.Serializable;
-
/**
* Interface defining a visitor for matrix entries.
*
@@ -26,7 +24,7 @@
* @version $Revision$ $Date$
* @since 2.0
*/
-public interface RealMatrixPreservingVisitor extends Serializable {
+public interface RealMatrixPreservingVisitor {
/**
* Start visiting a matrix.
Modified: commons/proper/math/trunk/src/java/org/apache/commons/math/ode/NordsieckTransformer.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/java/org/apache/commons/math/ode/NordsieckTransformer.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/java/org/apache/commons/math/ode/NordsieckTransformer.java (original)
+++ commons/proper/math/trunk/src/java/org/apache/commons/math/ode/NordsieckTransformer.java Sun May 24 16:44:52 2009
@@ -188,9 +188,6 @@
/** Convertor for {@link FieldMatrix}/{@link BigFraction}. */
private static class Convertor extends DefaultFieldMatrixPreservingVisitor<BigFraction> {
- /** Serializable version identifier. */
- private static final long serialVersionUID = -1799685632320460982L;
-
/** Converted array. */
private double[][] data;
Modified: commons/proper/math/trunk/src/test/org/apache/commons/math/linear/DenseFieldMatrixTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/org/apache/commons/math/linear/DenseFieldMatrixTest.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/org/apache/commons/math/linear/DenseFieldMatrixTest.java (original)
+++ commons/proper/math/trunk/src/test/org/apache/commons/math/linear/DenseFieldMatrixTest.java Sun May 24 16:44:52 2009
@@ -1247,7 +1247,6 @@
}
private static class SetVisitor extends DefaultFieldMatrixChangingVisitor<Fraction> {
- private static final long serialVersionUID = 6586716383170553060L;
public SetVisitor() {
super(Fraction.ZERO);
}
@@ -1258,7 +1257,6 @@
}
private static class GetVisitor extends DefaultFieldMatrixPreservingVisitor<Fraction> {
- private static final long serialVersionUID = 8363001284977267825L;
private int count;
public GetVisitor() {
super(Fraction.ZERO);
Modified: commons/proper/math/trunk/src/test/org/apache/commons/math/linear/DenseRealMatrixTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/org/apache/commons/math/linear/DenseRealMatrixTest.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/org/apache/commons/math/linear/DenseRealMatrixTest.java (original)
+++ commons/proper/math/trunk/src/test/org/apache/commons/math/linear/DenseRealMatrixTest.java Sun May 24 16:44:52 2009
@@ -1183,7 +1183,6 @@
}
private static class SetVisitor extends DefaultRealMatrixChangingVisitor {
- private static final long serialVersionUID = 1773444180892369386L;
@Override
public double visit(int i, int j, double value) {
return i + j / 1024.0;
@@ -1191,7 +1190,6 @@
}
private static class GetVisitor extends DefaultRealMatrixPreservingVisitor {
- private static final long serialVersionUID = -7745543227178932689L;
private int count = 0;
@Override
public void visit(int i, int j, double value) {
Modified: commons/proper/math/trunk/src/test/org/apache/commons/math/linear/FieldMatrixImplTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/org/apache/commons/math/linear/FieldMatrixImplTest.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/org/apache/commons/math/linear/FieldMatrixImplTest.java (original)
+++ commons/proper/math/trunk/src/test/org/apache/commons/math/linear/FieldMatrixImplTest.java Sun May 24 16:44:52 2009
@@ -933,7 +933,6 @@
}
private static class SetVisitor extends DefaultFieldMatrixChangingVisitor<Fraction> {
- private static final long serialVersionUID = -949750581026560454L;
public SetVisitor() {
super(Fraction.ZERO);
}
@@ -944,7 +943,6 @@
}
private static class GetVisitor extends DefaultFieldMatrixPreservingVisitor<Fraction> {
- private static final long serialVersionUID = -8008915491884412915L;
private int count;
public GetVisitor() {
super(Fraction.ZERO);
Modified: commons/proper/math/trunk/src/test/org/apache/commons/math/linear/RealMatrixImplTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/org/apache/commons/math/linear/RealMatrixImplTest.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/org/apache/commons/math/linear/RealMatrixImplTest.java (original)
+++ commons/proper/math/trunk/src/test/org/apache/commons/math/linear/RealMatrixImplTest.java Sun May 24 16:44:52 2009
@@ -963,7 +963,6 @@
private static class SetVisitor extends DefaultRealMatrixChangingVisitor {
- private static final long serialVersionUID = -5082825244208703349L;
@Override
public double visit(int i, int j, double value) {
return i + j / 1024.0;
@@ -971,7 +970,6 @@
}
private static class GetVisitor extends DefaultRealMatrixPreservingVisitor {
- private static final long serialVersionUID = 849639072339030818L;
private int count = 0;
@Override
public void visit(int i, int j, double value) {
Modified: commons/proper/math/trunk/src/test/org/apache/commons/math/linear/decomposition/QRDecompositionImplTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/org/apache/commons/math/linear/decomposition/QRDecompositionImplTest.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/org/apache/commons/math/linear/decomposition/QRDecompositionImplTest.java (original)
+++ commons/proper/math/trunk/src/test/org/apache/commons/math/linear/decomposition/QRDecompositionImplTest.java Sun May 24 16:44:52 2009
@@ -172,7 +172,6 @@
private void checkUpperTriangular(RealMatrix m) {
m.walkInOptimizedOrder(new DefaultRealMatrixPreservingVisitor() {
- private static final long serialVersionUID = -7685630069569815930L;
@Override
public void visit(int row, int column, double value) {
if (column < row) {
@@ -209,7 +208,6 @@
private void checkTrapezoidal(RealMatrix m) {
m.walkInOptimizedOrder(new DefaultRealMatrixPreservingVisitor() {
- private static final long serialVersionUID = -43649044361860701L;
@Override
public void visit(int row, int column, double value) {
if (column > row) {
@@ -258,7 +256,6 @@
private RealMatrix createTestMatrix(final Random r, final int rows, final int columns) {
RealMatrix m = MatrixUtils.createRealMatrix(rows, columns);
m.walkInOptimizedOrder(new DefaultRealMatrixChangingVisitor(){
- private static final long serialVersionUID = -556118291433400034L;
@Override
public double visit(int row, int column, double value)
throws MatrixVisitorException {
Modified: commons/proper/math/trunk/src/test/org/apache/commons/math/linear/decomposition/QRSolverTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/org/apache/commons/math/linear/decomposition/QRSolverTest.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/org/apache/commons/math/linear/decomposition/QRSolverTest.java (original)
+++ commons/proper/math/trunk/src/test/org/apache/commons/math/linear/decomposition/QRSolverTest.java Sun May 24 16:44:52 2009
@@ -199,7 +199,6 @@
RealMatrix b = a.multiply(xRef);
final double noise = 0.001;
b.walkInOptimizedOrder(new DefaultRealMatrixChangingVisitor() {
- private static final long serialVersionUID = 3533849820776962636L;
@Override
public double visit(int row, int column, double value) {
return value * (1.0 + noise * (2 * r.nextDouble() - 1));
@@ -232,7 +231,6 @@
private RealMatrix createTestMatrix(final Random r, final int rows, final int columns) {
RealMatrix m = MatrixUtils.createRealMatrix(rows, columns);
m.walkInOptimizedOrder(new DefaultRealMatrixChangingVisitor(){
- private static final long serialVersionUID = -556118291433400034L;
@Override
public double visit(int row, int column, double value)
throws MatrixVisitorException {
Modified: commons/proper/math/trunk/src/test/org/apache/commons/math/stat/regression/OLSMultipleLinearRegressionTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/org/apache/commons/math/stat/regression/OLSMultipleLinearRegressionTest.java?rev=778191&r1=778190&r2=778191&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/org/apache/commons/math/stat/regression/OLSMultipleLinearRegressionTest.java (original)
+++ commons/proper/math/trunk/src/test/org/apache/commons/math/stat/regression/OLSMultipleLinearRegressionTest.java Sun May 24 16:44:52 2009
@@ -95,7 +95,6 @@
final double[] s = { 1.0, -1.0 / 2.0, -1.0 / 3.0, -1.0 / 4.0, -1.0 / 5.0, -1.0 / 6.0 };
RealMatrix referenceVariance = new RealMatrixImpl(s.length, s.length);
referenceVariance.walkInOptimizedOrder(new DefaultRealMatrixChangingVisitor() {
- private static final long serialVersionUID = -6071126933773694288L;
@Override
public double visit(int row, int column, double value)
throws MatrixVisitorException {