You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/30 18:50:56 UTC

[GitHub] [tvm] rkimball edited a comment on pull request #6953: Add retry to sockets on EINTR error

rkimball edited a comment on pull request #6953:
URL: https://github.com/apache/tvm/pull/6953#issuecomment-735969815


   I have tested this on linux mostly but windows as well and I don't see any strange behavior where I need to hit ctrl-c multiple times to break. This change does not break ctrl-c support.
   EINTR support is already in the repo here https://github.com/apache/tvm/blob/main/apps/cpp_rpc/rpc_server.cc#L57-L63
   There is also support for EINTR in dmlc-core except there it will infinitely retry. 
   @areusch If there are specific tests you would like me to try then let me know. I have tested stopping the cpp rpc server with ctrl-c on windows and linux and everything works fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org