You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2010/02/23 20:44:28 UTC
[jira] Created: (PIG-1255) Tiny code cleanup for serialization code
for PigSplit
Tiny code cleanup for serialization code for PigSplit
-----------------------------------------------------
Key: PIG-1255
URL: https://issues.apache.org/jira/browse/PIG-1255
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: 0.6.0
Reporter: Daniel Dai
Assignee: Daniel Dai
Fix For: 0.7.0
A bug which close output stream while serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1255) Tiny code cleanup for serialization code
for PigSplit
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1255:
----------------------------
Attachment: PIG-1255-1.patch
> Tiny code cleanup for serialization code for PigSplit
> -----------------------------------------------------
>
> Key: PIG-1255
> URL: https://issues.apache.org/jira/browse/PIG-1255
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1255-1.patch
>
>
> A bug which close output stream while serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1255) Tiny code cleanup for serialization
code for PigSplit
Posted by "Pradeep Kamath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837496#action_12837496 ]
Pradeep Kamath commented on PIG-1255:
-------------------------------------
+1 to the changes since it is on the recommendation of the hadoop folks - but it would be good to know why is it a requirement that the Serializer/Deserialize should not be closed? It seems counter-intuitive.
> Tiny code cleanup for serialization code for PigSplit
> -----------------------------------------------------
>
> Key: PIG-1255
> URL: https://issues.apache.org/jira/browse/PIG-1255
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1255-1.patch, PIG-1255-2.patch
>
>
> A bug which close output stream while serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1255) Tiny code cleanup for serialization code
for PigSplit
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1255:
----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
No test included since this patch does not include any new feature. Patch committed.
> Tiny code cleanup for serialization code for PigSplit
> -----------------------------------------------------
>
> Key: PIG-1255
> URL: https://issues.apache.org/jira/browse/PIG-1255
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1255-1.patch, PIG-1255-2.patch
>
>
> A bug which close output stream while serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (PIG-1255) Tiny code cleanup for serialization code
for PigSplit
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai closed PIG-1255.
---------------------------
> Tiny code cleanup for serialization code for PigSplit
> -----------------------------------------------------
>
> Key: PIG-1255
> URL: https://issues.apache.org/jira/browse/PIG-1255
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1255-1.patch, PIG-1255-2.patch
>
>
> A bug which close output stream while serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1255) Tiny code cleanup for serialization code
for PigSplit
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1255:
----------------------------
Status: Patch Available (was: Open)
> Tiny code cleanup for serialization code for PigSplit
> -----------------------------------------------------
>
> Key: PIG-1255
> URL: https://issues.apache.org/jira/browse/PIG-1255
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1255-1.patch
>
>
> A bug which close output stream while serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1255) Tiny code cleanup for serialization code
for PigSplit
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1255:
----------------------------
Attachment: PIG-1255-2.patch
Checked with hadoop guys. For Serializer/Deserializer, we should always open, but never close. There is another place in pig code does not follow this. Attach a new patch address both positions.
> Tiny code cleanup for serialization code for PigSplit
> -----------------------------------------------------
>
> Key: PIG-1255
> URL: https://issues.apache.org/jira/browse/PIG-1255
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1255-1.patch, PIG-1255-2.patch
>
>
> A bug which close output stream while serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1255) Tiny code cleanup for serialization
code for PigSplit
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837541#action_12837541 ]
Hadoop QA commented on PIG-1255:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12436750/PIG-1255-1.patch
against trunk revision 915470.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/218/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/218/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/218/console
This message is automatically generated.
> Tiny code cleanup for serialization code for PigSplit
> -----------------------------------------------------
>
> Key: PIG-1255
> URL: https://issues.apache.org/jira/browse/PIG-1255
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.6.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.7.0
>
> Attachments: PIG-1255-1.patch, PIG-1255-2.patch
>
>
> A bug which close output stream while serialization.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.