Re: Review Request 57830: The logic of the solr_for_audit_setup installer parsing the properites file is inconsistent with the other installers. It treated these attributes as environment variable. There are security risks in the solr_for_audit_setup installer.

[Colm O hEigeartaigh <co...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57830/#review169685
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On March 22, 2017, 7:23 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57830/
> -----------------------------------------------------------
> 
> (Updated March 22, 2017, 7:23 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1470
>     https://issues.apache.org/jira/browse/RANGER-1470
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The logic of the solr_for_audit_setup installer parsing the properites file is inconsistent with the other installers. It treated these attributes as environment variable. There are security risks in the solr_for_audit_setup installer.
> 
> 
> Diffs
> -----
> 
>   security-admin/contrib/solr_for_audit_setup/setup.sh c4a8817 
> 
> 
> Diff: https://reviews.apache.org/r/57830/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>