You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jonbjo (via GitHub)" <gi...@apache.org> on 2026/02/12 20:21:24 UTC
[PR] fix(rest-catalog): omit null optional fields in CreateTableRequest JSON [iceberg-rust]
jonbjo opened a new pull request, #2136:
URL: https://github.com/apache/iceberg-rust/pull/2136
## Which issue does this PR close?
- Closes #2135
## What changes are included in this PR?
Adds #[serde(skip_serializing_if = "Option::is_none")] to optional fields in REST catalog request types to prevent serializing explicit null values.
## Are these changes tested?
Existing serialization tests continue to pass. This change affects JSON wire format only (omitting null vs. including it), which maintains compatibility with catalogs that accept either format while fixing compatibility with stricter implementations like Apache Polaris.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(rest-catalog): omit null optional fields in CreateTableRequest JSON [iceberg-rust]
Posted by "mattefunnel (via GitHub)" <gi...@apache.org>.
mattefunnel commented on PR #2136:
URL: https://github.com/apache/iceberg-rust/pull/2136#issuecomment-3937685749
I added some tests [here](https://github.com/apache/iceberg-rust/pull/2155).
That branch is based off of jonbjo:fix/skip-serialize-null-fields, so technically I guess that other PR "Closes the issue" as well. Not sure what is the best way to do a "Fork of a fork".
Any suggestions are welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(rest-catalog): omit null optional fields in CreateTableRequest JSON [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2136:
URL: https://github.com/apache/iceberg-rust/pull/2136#issuecomment-4107312624
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(rest-catalog): omit null optional fields in CreateTableRequest JSON [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2136:
URL: https://github.com/apache/iceberg-rust/pull/2136#issuecomment-4151439965
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(rest-catalog): omit null optional fields in CreateTableRequest JSON [iceberg-rust]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2136: fix(rest-catalog): omit null optional fields in CreateTableRequest JSON
URL: https://github.com/apache/iceberg-rust/pull/2136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(rest-catalog): omit null optional fields in CreateTableRequest JSON [iceberg-rust]
Posted by "mattefunnel (via GitHub)" <gi...@apache.org>.
mattefunnel commented on PR #2136:
URL: https://github.com/apache/iceberg-rust/pull/2136#issuecomment-4578592436
Trying to kick some life into this PR again, based off of [this message](https://apache-iceberg.slack.com/archives/C03LG1D563F/p1780075315101839?thread_ts=1780068437.558479&cid=C03LG1D563F) on the apache-iceberg slack.
Is there anything else that we should add here, @CTTY (and possibly @kevinjqliu?).
- if I understand the discussion above, the PR is approved (pending unit tests)
- we added a unit test [here](https://github.com/apache/iceberg-rust/pull/2136#issuecomment-3937685749) that — to the best of my knowledge — is in the same style as other nearby tests
If there is anything else we should / can do, please let me know :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org