You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/05/12 12:30:28 UTC

[GitHub] flink pull request #3884: [FLINK-6284] Correct sorting of completed checkpoi...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/3884

    [FLINK-6284] Correct sorting of completed checkpoints in ZooKeeperStateHandleStore

    In order to store completed checkpoints in an increasing order in ZooKeeper,
    the paths for the completed checkpoint is no generated by
    `String.format("/%019d", checkpointId)` instead of `String.format("/%s", checkpointId)`.
    This makes sure that the converted long will always have the same length with
    leading 0s.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixZooKeeperSorting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3884.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3884
    
----
commit 5bd499329d68c6f3236b4e89ba25fdb9acb7e422
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-05-12T12:23:37Z

    [FLINK-6284] Correct sorting of completed checkpoints in ZooKeeperStateHandleStore
    
    In order to store completed checkpoints in an increasing order in ZooKeeper,
    the paths for the completed checkpoint is no generated by
    String.format("/%019d", checkpointId) instead of String.format("/%s", checkpointId).
    This makes sure that the converted long will always have the same length with
    leading 0s.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3884: [FLINK-6284] Correct sorting of completed checkpoints in ...

Posted by StefanRRichter <gi...@git.apache.org>.

Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/3884
  
    LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3884: [FLINK-6284] Correct sorting of completed checkpoi...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3884


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3884: [FLINK-6284] Correct sorting of completed checkpoints in ...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3884
  
    Thanks for the review @StefanRRichter. Merging this PR once Travis gives green light.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---