You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/05/20 11:23:19 UTC
[GitHub] brooklyn-library pull request: BROOKLYN-272: disable failing non-d...
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-library/pull/39
BROOKLYN-272: disable failing non-deterministic tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-library BROOKLYN-272/disable-failing-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-library/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 6c56ec88a993d174973c7c035125153afe0e2e77
Author: Aled Sage <al...@gmail.com>
Date: 2016-05-20T11:22:21Z
BROOKLYN-272: disable failing non-deterministic tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: BROOKLYN-272: disable failing non-d...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-library/pull/39#issuecomment-221495680
Thanks @aledsage. Could you change this one to the `Broken` group as well, then good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: BROOKLYN-272: disable failing non-d...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-library/pull/39#issuecomment-221346224
Thanks @neykov
I've added the disabling of `ApplicationResourceTest.testFetchApplicationsAndEntity` to https://github.com/apache/brooklyn-server/pull/147. `PollerTest.testFeedContinuesWhenPollerThrows` was already disabled there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: BROOKLYN-272: disable failing non-d...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-library/pull/39#issuecomment-221515062
Thanks @neykov - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: BROOKLYN-272: disable failing non-d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-library/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request: BROOKLYN-272: disable failing non-d...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-library/pull/39#issuecomment-220590558
+1
Can we include the tests failing in the windows build as well. Here are a couple of recent failures:
* https://builds.apache.org/view/Brooklyn/job/brooklyn-master-windows/109
```
testFetchApplicationsAndEntity(org.apache.brooklyn.rest.resources.ApplicationResourceTest) Time elapsed: 0.073 sec <<< FAILURE!
java.lang.AssertionError: expected [4] but found [3]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:494)
at org.testng.Assert.assertEquals(Assert.java:123)
at org.testng.Assert.assertEquals(Assert.java:370)
at org.testng.Assert.assertEquals(Assert.java:380)
at org.apache.brooklyn.rest.resources.ApplicationResourceTest.testFetchApplicationsAndEntity(ApplicationResourceTest.java:387)
Results :
Failed tests:
ApplicationResourceTest.testFetchApplicationsAndEntity:387 expected [4] but found [3]
```
* https://builds.apache.org/view/Brooklyn/job/brooklyn-master-windows/117
```
AssertionError: entity=FeedExceptionEntityImpl{id=dYG0SKbP}; attribute=Sensor: flag (java.lang.Boolean) expected [false] but found [true]
at org.apache.brooklyn.test.Asserts.fail(Asserts.java:721)
at org.apache.brooklyn.test.Asserts.failNotEquals(Asserts.java:114)
at org.apache.brooklyn.test.Asserts.assertEquals(Asserts.java:436)
at org.apache.brooklyn.core.entity.EntityAsserts.assertAttributeEquals(EntityAsserts.java:54)
at org.apache.brooklyn.core.entity.EntityAsserts$1.run(EntityAsserts.java:70)
at org.apache.brooklyn.test.Asserts$RunnableAdapter.call(Asserts.java:1277)
at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:930)
at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:854)
at org.apache.brooklyn.core.entity.EntityAsserts.assertAttributeEqualsEventually(EntityAsserts.java:67)
at org.apache.brooklyn.core.feed.PollerTest.testFeedContinuesWhenPollerThrows(PollerTest.java:65)
2016-05-19 18:00:39,800 INFO Brooklyn shutdown: stopping entities [TestEntityImpl{id=gMtZBj5M}, TestEntityImpl{id=KJ03W2e9}, BlockingEntityImpl{id=ATsLvkYo}]
Results :
Failed tests:
org.apache.brooklyn.core.feed.PollerTest.testFeedContinuesWhenPollerThrows(org.apache.brooklyn.core.feed.PollerTest)
Run 1: PASS
Run 2: PollerTest.testFeedContinuesWhenPollerThrows:65 � PropagatedRuntime failed suc...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---