You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/10 11:35:44 UTC
[GitHub] [airflow] akolar-db opened a new pull request, #23620: Add git_source to DatabricksSubmitRunOperator
akolar-db opened a new pull request, #23620:
URL: https://github.com/apache/airflow/pull/23620
The existing `DatabricksSubmitRunOperator` is extended with the support for the `git_source` parameter which allows users to run notebook tasks from files committed to git repositories.
If specified, any notebook task that is part of the payload will clone the repository and check out the commit, tag, or the tip of the specified branch. This is an alternative to dev repos ([docs](https://docs.databricks.com/repos/index.html)) where the checkout/update would have to be triggered manually.
Public documentation for the feature available here: https://docs.databricks.com/dev-tools/api/latest/jobs.html (NB: as noted in the docs, the feature is currently in public preview).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23620: Add git_source to DatabricksSubmitRunOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #23620:
URL: https://github.com/apache/airflow/pull/23620#issuecomment-1122273238
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] akolar-db commented on a diff in pull request #23620: Add git_source to DatabricksSubmitRunOperator
Posted by GitBox <gi...@apache.org>.
akolar-db commented on code in PR #23620:
URL: https://github.com/apache/airflow/pull/23620#discussion_r871402772
##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -274,6 +274,7 @@ def __init__(
idempotency_token: Optional[str] = None,
access_control_list: Optional[List[Dict[str, str]]] = None,
wait_for_termination: bool = True,
+ git_source: Optional[Dict[str, str]] = None,
Review Comment:
Added, 0a264ada2. Could you please have another look to see if that's descriptive enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #23620: Add git_source to DatabricksSubmitRunOperator
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #23620:
URL: https://github.com/apache/airflow/pull/23620#discussion_r870504878
##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -274,6 +274,7 @@ def __init__(
idempotency_token: Optional[str] = None,
access_control_list: Optional[List[Dict[str, str]]] = None,
wait_for_termination: bool = True,
+ git_source: Optional[Dict[str, str]] = None,
Review Comment:
Can you add a docstring about it on L244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #23620: Add git_source to DatabricksSubmitRunOperator
Posted by GitBox <gi...@apache.org>.
kaxil merged PR #23620:
URL: https://github.com/apache/airflow/pull/23620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23620: Add git_source to DatabricksSubmitRunOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #23620:
URL: https://github.com/apache/airflow/pull/23620#issuecomment-1125867811
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23620: Add git_source to DatabricksSubmitRunOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23620:
URL: https://github.com/apache/airflow/pull/23620#issuecomment-1122611873
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #23620: Add git_source to DatabricksSubmitRunOperator
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #23620:
URL: https://github.com/apache/airflow/pull/23620#discussion_r869485739
##########
tests/providers/databricks/operators/test_databricks.py:
##########
@@ -193,6 +193,24 @@ def test_init_with_templating(self):
)
assert expected == op.json
+ def test_init_with_git_source(self):
+ json = {'new_cluster': NEW_CLUSTER, 'notebook_task': NOTEBOOK_TASK, 'run_name': RUN_NAME}
+ git_source = {
+ 'git_url': 'https://github.com/apache/airflow',
+ 'git_provider': 'github',
+ 'git_branch': 'main',
+ }
+ op = DatabricksSubmitRunOperator(task_id=TASK_ID, git_source=git_source, json=json)
+ expected = databricks_operator._deep_string_coerce(
+ {
+ 'new_cluster': NEW_CLUSTER,
+ 'notebook_task': NOTEBOOK_TASK,
+ 'run_name': RUN_NAME,
+ 'git_source': git_source
Review Comment:
```suggestion
'git_source': git_source,
```
To fix static check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org