You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/02/15 03:08:39 UTC
[GitHub] [submarine] liuxunorg opened a new pull request #183:
SUBMARINE-380. Optimize submarine-cloud to create kind cluster script
liuxunorg opened a new pull request #183: SUBMARINE-380. Optimize submarine-cloud to create kind cluster script
URL: https://github.com/apache/submarine/pull/183
### What is this PR for?
In the submarine-cloud script for creating a kind cluster,
If the user does not have kind bin installed, after the automatic download, the user is required to manually set the kind to the PATH environment variable.
We need to provide a kind script in the submarine project. This script proxy all kind bin commands. If the kind bin file is not installed locally, the kind script will automatically download the kind bin file. All kind bin operations are performed by this kind script, so that the user does not need to set the PATH environment variable.
### What type of PR is it?
Improvement
### Todos
* [ ] - submarine-test/k8s
### What is the Jira issue?
* https://issues.apache.org/jira/browse/SUBMARINE-380
### How should this be tested?
1. execute `submarine-cloud/hack/kind-create-cluster.sh`
2. execute `submarine-cloud/hack/deploy-submarine.sh`
3. open `http://127.0.0.1` in chrome, you can see submarine workbench
4. execute `submarine-cloud/hack/deploy-submarine.sh -u`, uninstall submarine in kind
5. execute `kind delete cluster`
* https://travis-ci.org/liuxunorg/submarine/builds/650709676
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #183: SUBMARINE-380.
Optimize create kind cluster scripts
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #183: SUBMARINE-380. Optimize create kind cluster scripts
URL: https://github.com/apache/submarine/pull/183
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] tangzhankun commented on issue #183: SUBMARINE-380.
Optimize create kind cluster scripts
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on issue #183: SUBMARINE-380. Optimize create kind cluster scripts
URL: https://github.com/apache/submarine/pull/183#issuecomment-586549973
Thx Xun. LGTM.+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #183: SUBMARINE-380.
Optimize create kind cluster scripts
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #183: SUBMARINE-380. Optimize create kind cluster scripts
URL: https://github.com/apache/submarine/pull/183#issuecomment-586550059
@tangzhankun Thank you help review.
Will merge if no more comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org