[GitHub] [systemds] fathollahzadeh commented on a diff in pull request #1672: [GIO] New Implementation of IOGEN

[GitBox <gi...@apache.org>]

fathollahzadeh commented on code in PR #1672:
URL: https://github.com/apache/systemds/pull/1672#discussion_r953999101


##########
src/main/java/org/apache/sysds/hops/DataOp.java:
##########
@@ -283,20 +308,28 @@ public Lop constructLops()
 		for (Entry<String, Integer> cur : _paramIndexMap.entrySet()) {
 			inputLops.put(cur.getKey(), getInput().get(cur.getValue()).constructLops());
 		}
+		if(_ioGenRead)
+			inputLops.put("iogenformat", _generateReaderOp.constructLops());
 
 		// Create the lop
 		switch(_op) 
 		{
 			case TRANSIENTREAD:
-				l = new Data(_op, null, inputLops, getName(), null, 
-						getDataType(), getValueType(), getFileFormat());
+				if(!_ioGenRead)
+					l = new Data(_op, null, inputLops, getName(), null, getDataType(), getValueType(), getFileFormat());
+				else
+					l = new DataIOGen(_op, null, inputLops, getName(), null, getDataType(), getValueType(), getIOGenFormat());

Review Comment:
   We are identifying the format and generating corresponding readers to that and then reusing it multiple times, I think it can be Transient.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org