You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/19 12:44:49 UTC
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1603: Ftr/triple reflect support
LaurenceLiZhixin opened a new pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#issuecomment-975031423
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1603](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc8d960) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/5c115cbc3cba9bd4eeb4342bfdb58e10098bac4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c115cb) will **decrease** coverage by `0.19%`.
> The diff coverage is `27.74%`.
> :exclamation: Current head dc8d960 differs from pull request most recent head 5029819. Consider uploading reports for the commit 5029819 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1603 +/- ##
==========================================
- Coverage 41.09% 40.89% -0.20%
==========================================
Files 251 251
Lines 14319 14402 +83
==========================================
+ Hits 5884 5890 +6
- Misses 7747 7831 +84
+ Partials 688 681 -7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `21.42% <0.00%> (-2.34%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <ø> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `10.98% <ø> (ø)` | |
| [filter/accesslog/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2FjY2Vzc2xvZy9maWx0ZXIuZ28=) | `32.77% <0.00%> (-0.57%)` | :arrow_down: |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `59.01% <0.00%> (-1.49%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `19.58% <9.09%> (-3.79%)` | :arrow_down: |
| [filter/auth/provider\_auth\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvcHJvdmlkZXJfYXV0aF9maWx0ZXIuZ28=) | `36.36% <18.18%> (-16.58%)` | :arrow_down: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <22.22%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c115cb...5029819](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#issuecomment-974785819
目前 Dubbo-go service 需要用户在配置中填写 InterfacenName，但由于 pb 文件的接口名规范是从pb文件内读取的，也就是proto 文件中的 package 字段，例如：
```proto
syntax = "proto3";
option go_package = "github.com/dubbogo/grpc-go/reflection/triple_reflection_v1alpha";
package triple.reflection.v1alpha;
service UserProvider {
}
```
在这种规范下，UserProvider 的接口全名为 triple.reflection.v1alpha.UserProvider，框架需要遵循 pb 文件的接口名，才能保证跨语言互通，与 grpc 互通。
Triple 之前的实现，为了兼容用户interfaceName 编写习惯，忽略了pb 中的接口名，强制使用用户在配置中定义的interfaceName 作为接口名。但在 pb 反射支持之后，这将带来问题，因为pb 文件中的接口名是静态的，用户配置中的接口名是动态的。
经过考虑，我选择了这种方式来解决冲突：如果用户在配置中定义interfaceName，将优先使用该字段。如果未定义，会从pb 文件中读取package name。用户未定义接口名的情况，只能出现在 triple 协议 pb 序列化的情况下。这种设计与之前完全兼容。
从pb文件中读取package name的接口会在 _triple.pb.go 文件中定义
protoc-gen-go-triple@v1.0.5 之后支持，与旧版本兼容：
```go
func (s *UnimplementedGreeterServer) XXX_InterfaceName() string {
return "org.apache.dubbogo.samples.api.Greeter"
}
```
@AlexStocks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#issuecomment-975031423
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1603](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c98aafb) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/5c115cbc3cba9bd4eeb4342bfdb58e10098bac4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c115cb) will **decrease** coverage by `0.17%`.
> The diff coverage is `5.00%`.
> :exclamation: Current head c98aafb differs from pull request most recent head 0caa028. Consider uploading reports for the commit 0caa028 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1603 +/- ##
==========================================
- Coverage 41.09% 40.91% -0.18%
==========================================
Files 251 251
Lines 14319 14402 +83
==========================================
+ Hits 5884 5893 +9
- Misses 7747 7828 +81
+ Partials 688 681 -7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `21.42% <0.00%> (-2.34%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <ø> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `10.98% <ø> (ø)` | |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `59.01% <0.00%> (-1.49%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `19.58% <9.09%> (-3.79%)` | :arrow_down: |
| [filter/auth/accesskey\_storage.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvYWNjZXNza2V5X3N0b3JhZ2UuZ28=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [filter/auth/provider\_auth\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvcHJvdmlkZXJfYXV0aF9maWx0ZXIuZ28=) | `36.36% <0.00%> (-16.58%)` | :arrow_down: |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c115cb...0caa028](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#discussion_r753784200
##########
File path: config/service_config.go
##########
@@ -51,7 +51,7 @@ type ServiceConfig struct {
id string
Filter string `yaml:"filter" json:"filter,omitempty" property:"filter"`
ProtocolIDs []string `yaml:"protocol-ids" json:"protocol-ids,omitempty" property:"protocol-ids"` // multi protocolIDs support, split by ','
- Interface string `validate:"required" yaml:"interface" json:"interface,omitempty" property:"interface"`
Review comment:
这里 validate tag 和上面的 required tag 应该是分别做两个事，上面的 required 删掉我理解，因为如果不设置值就尝试使用 pb 里的值，但这里的 validate 为啥删掉呢，pb 里读到的不需要校验嘛？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#discussion_r753330057
##########
File path: config/consumer_config.go
##########
@@ -74,8 +75,23 @@ func (cc *ConsumerConfig) Init(rc *RootConfig) error {
break
}
}
- for _, reference := range cc.References {
- if err := reference.Init(rc); err != nil {
+ for key, referenceConfig := range cc.References {
+ if referenceConfig.InterfaceName == "" {
+ reference := GetConsumerService(key)
+ // try to use interface name defined by pb
+ supportPBPackagerNameReference, ok := reference.(common.TriplePBService)
+ if !ok {
+ logger.Errorf("Reference with reference = %s is not support read interface name from it."+
Review comment:
"Dubbogo cannot get interface namefrom Reference with reference = %s."+
"Please run the command \"go install github.com/dubbogo/tools/cmd/protoc-gen-go-triple@latest\" to get the latest "+
"protoc-gen-go-triple, and then re-generate your pb file again by this tool."+
"If you are not using pb serialization, please set 'interface' field in reference config."
##########
File path: config/consumer_config.go
##########
@@ -74,8 +75,23 @@ func (cc *ConsumerConfig) Init(rc *RootConfig) error {
break
}
}
- for _, reference := range cc.References {
- if err := reference.Init(rc); err != nil {
+ for key, referenceConfig := range cc.References {
+ if referenceConfig.InterfaceName == "" {
+ reference := GetConsumerService(key)
+ // try to use interface name defined by pb
+ supportPBPackagerNameReference, ok := reference.(common.TriplePBService)
+ if !ok {
+ logger.Errorf("Reference with reference = %s is not support read interface name from it."+
Review comment:
"Dubbogo cannot get interface namefrom Reference with reference = %s."+
"Please run the command \"go install github.com/dubbogo/tools/cmd/protoc-gen-go-triple@latest\" to get the latest "+
"protoc-gen-go-triple, and then re-generate your pb file again by this tool."+
"If you are not using pb serialization, please set 'interfaceName' field in reference config to let the dubbogo get the interface name."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#discussion_r753919408
##########
File path: config/consumer_config.go
##########
@@ -74,8 +75,23 @@ func (cc *ConsumerConfig) Init(rc *RootConfig) error {
break
}
}
- for _, reference := range cc.References {
- if err := reference.Init(rc); err != nil {
+ for key, referenceConfig := range cc.References {
+ if referenceConfig.InterfaceName == "" {
+ reference := GetConsumerService(key)
+ // try to use interface name defined by pb
+ supportPBPackagerNameReference, ok := reference.(common.TriplePBService)
+ if !ok {
+ logger.Errorf("Reference with reference = %s is not support read interface name from it."+
Review comment:
Fixed
##########
File path: config/consumer_config.go
##########
@@ -74,8 +75,23 @@ func (cc *ConsumerConfig) Init(rc *RootConfig) error {
break
}
}
- for _, reference := range cc.References {
- if err := reference.Init(rc); err != nil {
+ for key, referenceConfig := range cc.References {
+ if referenceConfig.InterfaceName == "" {
+ reference := GetConsumerService(key)
+ // try to use interface name defined by pb
+ supportPBPackagerNameReference, ok := reference.(common.TriplePBService)
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin merged pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#issuecomment-974785819
目前 Dubbo-go service 需要用户在配置中填写 InterfacenName，但由于 pb 文件的接口名规范是从pb文件内读取的，也就是proto 文件中的 package 字段，例如：
```proto
syntax = "proto3";
option go_package = "github.com/dubbogo/grpc-go/reflection/triple_reflection_v1alpha";
package triple.reflection.v1alpha;
service UserProvider {
}
```
在这种规范下，UserProvider 的接口全名为 triple.reflection.v1alpha.UserProvider，框架需要遵循 pb 文件的接口名，才能保证跨语言互通，与 grpc 互通。
Triple 之前的实现，为了兼容用户interfaceName 编写习惯，忽略了pb 中的接口名，强制使用用户在配置中定义的interfaceName 作为接口名。但在 pb 反射支持之后，这将带来问题，因为pb 文件中的接口名是静态的，用户配置中的接口名是动态的。
经过考虑，我选择了这种方式来解决冲突：如果用户在配置中定义interfaceName，将优先使用该字段。如果未定义，会从pb 文件中读取package name。用户未定义接口名的情况，只能出现在 triple 协议 pb 序列化的情况下。这种设计与之前完全兼容。
从pb文件中读取package name的接口会在 _triple.pb.go 文件中定义
protoc-gen-go-triple@v1.0.5 之后支持，与旧版本兼容：
```go
func (s *UnimplementedGreeterServer) XXX_InterfaceName() string {
return "org.apache.dubbogo.samples.api.Greeter"
}
```
@AlexStocks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#issuecomment-975031423
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1603](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc8d960) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/5c115cbc3cba9bd4eeb4342bfdb58e10098bac4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c115cb) will **decrease** coverage by `0.19%`.
> The diff coverage is `27.74%`.
> :exclamation: Current head dc8d960 differs from pull request most recent head 0caa028. Consider uploading reports for the commit 0caa028 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1603 +/- ##
==========================================
- Coverage 41.09% 40.89% -0.20%
==========================================
Files 251 251
Lines 14319 14402 +83
==========================================
+ Hits 5884 5890 +6
- Misses 7747 7831 +84
+ Partials 688 681 -7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `21.42% <0.00%> (-2.34%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <ø> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `10.98% <ø> (ø)` | |
| [filter/accesslog/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2FjY2Vzc2xvZy9maWx0ZXIuZ28=) | `32.77% <0.00%> (-0.57%)` | :arrow_down: |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `59.01% <0.00%> (-1.49%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `19.58% <9.09%> (-3.79%)` | :arrow_down: |
| [filter/auth/provider\_auth\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvcHJvdmlkZXJfYXV0aF9maWx0ZXIuZ28=) | `36.36% <18.18%> (-16.58%)` | :arrow_down: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <22.22%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c115cb...0caa028](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#issuecomment-975031423
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1603](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dc8d960) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/5c115cbc3cba9bd4eeb4342bfdb58e10098bac4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c115cb) will **decrease** coverage by `0.19%`.
> The diff coverage is `27.74%`.
> :exclamation: Current head dc8d960 differs from pull request most recent head c98aafb. Consider uploading reports for the commit c98aafb to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1603 +/- ##
==========================================
- Coverage 41.09% 40.89% -0.20%
==========================================
Files 251 251
Lines 14319 14402 +83
==========================================
+ Hits 5884 5890 +6
- Misses 7747 7831 +84
+ Partials 688 681 -7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `21.42% <0.00%> (-2.34%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <ø> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `10.98% <ø> (ø)` | |
| [filter/accesslog/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2FjY2Vzc2xvZy9maWx0ZXIuZ28=) | `32.77% <0.00%> (-0.57%)` | :arrow_down: |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `59.01% <0.00%> (-1.49%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `19.58% <9.09%> (-3.79%)` | :arrow_down: |
| [filter/auth/provider\_auth\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvcHJvdmlkZXJfYXV0aF9maWx0ZXIuZ28=) | `36.36% <18.18%> (-16.58%)` | :arrow_down: |
| [filter/auth/consumer\_sign\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvY29uc3VtZXJfc2lnbl9maWx0ZXIuZ28=) | `44.44% <22.22%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c115cb...c98aafb](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#discussion_r753330057
##########
File path: config/consumer_config.go
##########
@@ -74,8 +75,23 @@ func (cc *ConsumerConfig) Init(rc *RootConfig) error {
break
}
}
- for _, reference := range cc.References {
- if err := reference.Init(rc); err != nil {
+ for key, referenceConfig := range cc.References {
+ if referenceConfig.InterfaceName == "" {
+ reference := GetConsumerService(key)
+ // try to use interface name defined by pb
+ supportPBPackagerNameReference, ok := reference.(common.TriplePBService)
+ if !ok {
+ logger.Errorf("Reference with reference = %s is not support read interface name from it."+
Review comment:
Reference with reference = %s is not support read interface name from it."+
"Please run \"go install github.com/dubbogo/tools/cmd/protoc-gen-go-triple@latest\" to update your "+
"protoc-gen-go-triple and re-generate your pb file again."+
"If you are not using pb serialization, please set 'interface' field in reference config."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#discussion_r753845575
##########
File path: config/consumer_config.go
##########
@@ -74,8 +75,23 @@ func (cc *ConsumerConfig) Init(rc *RootConfig) error {
break
}
}
- for _, reference := range cc.References {
- if err := reference.Init(rc); err != nil {
+ for key, referenceConfig := range cc.References {
+ if referenceConfig.InterfaceName == "" {
+ reference := GetConsumerService(key)
+ // try to use interface name defined by pb
+ supportPBPackagerNameReference, ok := reference.(common.TriplePBService)
Review comment:
这名字太别扭了，竟然是动词开头的名称。referenceInterfaceName 就可以了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#discussion_r753784200
##########
File path: config/service_config.go
##########
@@ -51,7 +51,7 @@ type ServiceConfig struct {
id string
Filter string `yaml:"filter" json:"filter,omitempty" property:"filter"`
ProtocolIDs []string `yaml:"protocol-ids" json:"protocol-ids,omitempty" property:"protocol-ids"` // multi protocolIDs support, split by ','
- Interface string `validate:"required" yaml:"interface" json:"interface,omitempty" property:"interface"`
Review comment:
这里 validate tag 和上面的 required tag 应该是分别做两个事，上面的 required 删掉我理解，因为如果不设置值就尝试使用 pb 里的值，但这里的 validate 为啥删掉呢，pb 里读到的不需要校验嘛？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#issuecomment-975031423
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1603](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (451d10a) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/5c115cbc3cba9bd4eeb4342bfdb58e10098bac4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c115cb) will **decrease** coverage by `0.12%`.
> The diff coverage is `5.00%`.
> :exclamation: Current head 451d10a differs from pull request most recent head 5029819. Consider uploading reports for the commit 5029819 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1603 +/- ##
==========================================
- Coverage 41.09% 40.96% -0.13%
==========================================
Files 251 251
Lines 14319 14353 +34
==========================================
- Hits 5884 5880 -4
- Misses 7747 7782 +35
- Partials 688 691 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `21.42% <0.00%> (-2.34%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <ø> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `10.98% <ø> (ø)` | |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `59.01% <0.00%> (-1.49%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `19.58% <9.09%> (-3.79%)` | :arrow_down: |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `85.00% <0.00%> (-15.00%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `41.37% <0.00%> (-3.45%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c115cb...5029819](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#discussion_r753917078
##########
File path: config/service_config.go
##########
@@ -51,7 +51,7 @@ type ServiceConfig struct {
id string
Filter string `yaml:"filter" json:"filter,omitempty" property:"filter"`
ProtocolIDs []string `yaml:"protocol-ids" json:"protocol-ids,omitempty" property:"protocol-ids"` // multi protocolIDs support, split by ','
- Interface string `validate:"required" yaml:"interface" json:"interface,omitempty" property:"interface"`
Review comment:
我确认了下，都要删掉。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#issuecomment-974882197
> 目前 Dubbo-go service 需要用户在配置中填写 InterfacenName，但由于 pb 文件的接口名规范是从pb文件内读取的，也就是proto 文件中的 package 字段，例如：
>
> ```proto
> syntax = "proto3";
>
> option go_package = "github.com/dubbogo/grpc-go/reflection/triple_reflection_v1alpha";
>
> package triple.reflection.v1alpha;
>
> service UserProvider {
> }
> ```
>
> 在这种规范下，UserProvider 的接口全名为 triple.reflection.v1alpha.UserProvider，框架需要遵循 pb 文件的接口名，才能保证跨语言互通，与 grpc 互通。 Triple 之前的实现，为了兼容用户interfaceName 编写习惯，忽略了pb 中的接口名，强制使用用户在配置中定义的interfaceName 作为接口名。但在 pb 反射支持之后，这将带来问题，因为pb 文件中的接口名是静态的，用户配置中的接口名是动态的。
>
> 经过考虑，我选择了这种方式来解决冲突：如果用户在配置中定义interfaceName，将优先使用该字段。如果未定义，会从pb 文件中读取package name。用户未定义接口名的情况，只能出现在 triple 协议 pb 序列化的情况下。这种设计与之前完全兼容。
>
> 从pb文件中读取package name的接口会在 _triple.pb.go 文件中定义 protoc-gen-go-triple@v1.0.5 之后支持，与旧版本兼容：
>
> ```go
> func (s *UnimplementedGreeterServer) XXX_InterfaceName() string {
> return "org.apache.dubbogo.samples.api.Greeter"
> }
> ```
>
> @AlexStocks
英文 log 我更新过了，你再看看。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1603: Ftr/triple reflect support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1603:
URL: https://github.com/apache/dubbo-go/pull/1603#issuecomment-975031423
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1603](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0caa028) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/5c115cbc3cba9bd4eeb4342bfdb58e10098bac4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c115cb) will **decrease** coverage by `0.17%`.
> The diff coverage is `5.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1603 +/- ##
==========================================
- Coverage 41.09% 40.91% -0.18%
==========================================
Files 251 251
Lines 14319 14402 +83
==========================================
+ Hits 5884 5893 +9
- Misses 7747 7829 +82
+ Partials 688 680 -8
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `21.42% <0.00%> (-2.34%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <ø> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `10.98% <ø> (ø)` | |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `59.01% <0.00%> (-1.49%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `19.58% <9.09%> (-3.79%)` | :arrow_down: |
| [filter/auth/accesskey\_storage.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvYWNjZXNza2V5X3N0b3JhZ2UuZ28=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [filter/auth/provider\_auth\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2F1dGgvcHJvdmlkZXJfYXV0aF9maWx0ZXIuZ28=) | `36.36% <0.00%> (-16.58%)` | :arrow_down: |
| [filter/echo/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2VjaG8vZmlsdGVyLmdv) | `50.00% <0.00%> (-11.54%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/dubbo-go/pull/1603/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5c115cb...0caa028](https://codecov.io/gh/apache/dubbo-go/pull/1603?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org