You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "hujun260 (via GitHub)" <gi...@apache.org> on 2023/09/07 02:41:47 UTC

[GitHub] [nuttx] hujun260 opened a new pull request, #10500: cxd56xx: rm sched_[un]lock

hujun260 opened a new pull request, #10500:
URL: https://github.com/apache/nuttx/pull/10500

   ## Summary
   cxd56xx: rm sched_[un]lock
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #10500: cxd56xx: rm sched_[un]lock

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10500:
URL: https://github.com/apache/nuttx/pull/10500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] hujun260 commented on a diff in pull request #10500: cxd56xx: rm sched_[un]lock

Posted by "hujun260 (via GitHub)" <gi...@apache.org>.
hujun260 commented on code in PR #10500:
URL: https://github.com/apache/nuttx/pull/10500#discussion_r1318273044


##########
arch/arm/src/cxd56xx/cxd56_cpu1signal.c:
##########
@@ -188,8 +186,6 @@ int cxd56_cpu1siginit(uint8_t sigtype, void *data)
 
   priv->ndev++;
 

Review Comment:
   According to the current implementation, "cxd56_cpu1siguninit" will only be called once during the NuttX startup phase, and it won't involve scenarios of multi-threaded concurrent access.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #10500: cxd56xx: rm sched_[un]lock

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #10500:
URL: https://github.com/apache/nuttx/pull/10500#discussion_r1318258123


##########
arch/arm/src/cxd56xx/cxd56_cpu1signal.c:
##########
@@ -188,8 +186,6 @@ int cxd56_cpu1siginit(uint8_t sigtype, void *data)
 
   priv->ndev++;
 

Review Comment:
   Do we have any protection now for `priv->ndev` access done from multiple threads?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org