[jira] [Created] (SLIDER-1155) Code issues - 16 multithreaded correctness

["Gour Saha (JIRA)" <ji...@apache.org>]

Gour Saha created SLIDER-1155:
---------------------------------

             Summary: Code issues - 16 multithreaded correctness
                 Key: SLIDER-1155
                 URL: https://issues.apache.org/jira/browse/SLIDER-1155
             Project: Slider
          Issue Type: Bug
          Components: other
    Affects Versions: Slider 0.91
            Reporter: Gour Saha


Following 16 possible multithreaded correctness issues need to be evaluated and fixed.

h6. slider-core/src/main/java/org/apache/slider/server/services/workflow/ForkedProcessService.java
{code}
244    synchronized (processTerminated) {
{code}
defect: Synchronization performed on java.util.concurrent.atomic.AtomicBoolean

{code}
213      synchronized (processTerminated) {
{code}
defect: Synchronization performed on java.util.concurrent.atomic.AtomicBoolean

h6. slider-core/src/main/java/org/apache/slider/server/appmaster/state/RoleStatus.java
{code}
320  public long getCompleted() {
{code}
defect: org.apache.slider.server.appmaster.state.RoleStatus.getCompleted() is unsynchronized, org.apache.slider.server.appmaster.state.RoleStatus.setCompleted(int) is synchronized.

h6. slider-core/src/main/java/org/apache/slider/server/appmaster/state/ProviderAppState.java
{code}
94      synchronized (publishedConfigSets) {
{code}
defect: Synchronization performed on java.util.concurrent.ConcurrentHashMap

{code}
110    synchronized (publishedConfigSets) {
{code}
defect: Synchronization performed on java.util.concurrent.ConcurrentHashMap

h6. slider-core/src/main/java/org/apache/slider/server/appmaster/management/RecordedEvent.java
{code}
54    this.time = timestamp > 0 ? dateFormat.format(timestamp) : "";
{code}
defect: Call to method of static java.text.DateFormat

h6. slider-core/src/main/java/org/apache/slider/server/appmaster/management/RangeLimitedCounter.java
{code}
77  public long get() {
{code}
defect: org.apache.slider.server.appmaster.management.RangeLimitedCounter.get() is unsynchronized, org.apache.slider.server.appmaster.management.RangeLimitedCounter.set(long) is synchronized.

h6. slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java
{code}
1532        isAMCompleted.awaitUninterruptibly();
{code}
defect: Condition.await() not in loop.

h6. slider-core/src/main/java/org/apache/slider/providers/agent/ComponentTagProvider.java
{code}
119      synchronized (allTags) {
{code}
defect: Synchronization performed on java.util.concurrent.ConcurrentHashMap

{code}
 56              compTags.put(tempKey, FREE);
{code}
defect: Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic.

{code}
106        synchronized (compTags) {
{code}
defect: Synchronization performed on java.util.concurrent.ConcurrentHashMap

{code}
 52        synchronized (compTags) {
{code}
defect: Synchronization performed on java.util.concurrent.ConcurrentHashMap

{code}
121          allTags.put(component, new ConcurrentHashMap<String, String>());
{code}
defect: Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic

{code}
 76      synchronized (compTags) {
{code}
defect: Synchronization performed on java.util.concurrent.ConcurrentHashMap

h6. slider-core/src/main/java/org/apache/slider/core/zk/BlockingZKWatcher.java
{code}
39    synchronized (connectedFlag) {
{code}
defect: Synchronization performed on java.util.concurrent.atomic.AtomicBoolean

{code}
55    synchronized (connectedFlag) {
{code}
defect: Synchronization performed on java.util.concurrent.atomic.AtomicBoolean




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)