[GitHub] [incubator-devlake] klesh commented on a diff in pull request #3166: Add a snapshot structure and add commitLineChange table

[GitBox <gi...@apache.org>]

klesh commented on code in PR #3166:
URL: https://github.com/apache/incubator-devlake/pull/3166#discussion_r978243510


##########
plugins/gitextractor/tasks/git_repo_collector.go:
##########
@@ -84,6 +84,16 @@ func CollectGitTags(subTaskCtx core.SubTaskContext) errors.Error {
 	}
 	return repo.CollectTags(subTaskCtx)
 }
+func CollectGitDiffLines(subTaskCtx core.SubTaskContext) errors.Error {

Review Comment:
   Please add an empty between functions



##########
plugins/gitextractor/store/csv.go:
##########
@@ -138,6 +138,10 @@ func (c *CsvStore) CommitFileComponents(commitFileComponent *code.CommitFileComp
 	return c.commitFileWriter.Write(commitFileComponent)
 }
 
+func (c *CsvStore) CommitLineChange(commitLineChange *code.CommitLineChange) errors.Error {
+	return c.commitFileWriter.Write(commitLineChange)

Review Comment:
   This is incorrect, different entities should be written to separate files.
   I also notice the `CommitFileComponents` is writing to the `commit_files.csv`, please fix that as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org