[jira] [Commented] (MAHOUT-1050) mutable in-memory datamodel

["Sebastian Schelter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428829#comment-13428829 ] 

Sebastian Schelter commented on MAHOUT-1050:
--------------------------------------------

Hi Renaud,

I really like the idea of having a mutable in-memory datamodel. I think however that such an implementation should be threadsafe and I don't think that this is already the case with your implementation. 

What do you think? Could you enhance the patch to make the model threadsafe?


Btw: Your patch doesn't adhere to Mahout style guidelines and Apache doesn't allow @author tags.
                
> mutable in-memory datamodel
> ---------------------------
>
>                 Key: MAHOUT-1050
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1050
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Collaborative Filtering
>    Affects Versions: 0.7
>         Environment: independant
>            Reporter: Renaud Richardet
>            Assignee: Sean Owen
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: MutableDataModel.java
>
>
> I could not find an in-memory DataModel that supports setPreference / removePreference / refresh. Instead, they all "recreate" a new GenericDataModel anytime one adds or remove preferences. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira