You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2024/08/05 14:27:11 UTC

[PR] [FFI] Remove backwards-compatibility unwrapping of IntImm [tvm]

Lunderberg opened a new pull request, #17241:
URL: https://github.com/apache/tvm/pull/17241

   This is a follow-up PR to https://github.com/apache/tvm/pull/16183, which updated the FFI with explicit integer types.  As part of that change, many internal functions were updated to accept non-IR types (e.g. `Array<runtime::Int>` instead of `Array<IntImm>`).  For backwards compatibility with callees that provided the IR types, a specialization of `PackedFuncValueConverter` unwrapped the `IntImm` into a `runtime::Int`.
   
   This commit removes the backwards-compatibility specialization of `PackedFuncValueConverter`.  Breakages that are found in CI as a result will then be updated at the caller side, removing the need for the backwards-compatibility handler altogether.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][FFI] Remove backwards-compatibility unwrapping of IntImm [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #17241:
URL: https://github.com/apache/tvm/pull/17241#issuecomment-2350953183

   Given these are legacy. I think we can remove those tests to move forward 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][FFI] Remove backwards-compatibility unwrapping of IntImm [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen closed pull request #17241: [Draft][FFI] Remove backwards-compatibility unwrapping of IntImm
URL: https://github.com/apache/tvm/pull/17241


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][FFI] Remove backwards-compatibility unwrapping of IntImm [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #17241:
URL: https://github.com/apache/tvm/pull/17241#issuecomment-2334033103

   would be great to followup on this one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][FFI] Remove backwards-compatibility unwrapping of IntImm [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #17241:
URL: https://github.com/apache/tvm/pull/17241#issuecomment-2856741161

   superseded by #17920 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][FFI] Remove backwards-compatibility unwrapping of IntImm [tvm]

Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #17241:
URL: https://github.com/apache/tvm/pull/17241#issuecomment-2368228230

   would be great to check the remaining errors and get this in


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Draft][FFI] Remove backwards-compatibility unwrapping of IntImm [tvm]

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17241:
URL: https://github.com/apache/tvm/pull/17241#issuecomment-2346974902

   Agreed, though unfortunately I haven't had time to do so.  It looks like the current failures are in the relay/collage C++ testing, but I haven't looking into it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FFI] Remove backwards-compatibility unwrapping of IntImm [tvm]

Posted by "Lunderberg (via GitHub)" <gi...@apache.org>.
Lunderberg commented on PR #17241:
URL: https://github.com/apache/tvm/pull/17241#issuecomment-2269215892

   The initial commit in this PR branch only removes the backwards-compatibility handler, and does not yet update any callers.  This is expected to trigger breakage in CI, which will identify the callers that must be updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org