You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/04 04:24:29 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #813: ORC-907: Remove junit-vintage-engine from core module
dongjoon-hyun opened a new pull request #813:
URL: https://github.com/apache/orc/pull/813
### What changes were proposed in this pull request?
This PR removes
### Why are the changes needed?
After this PR, Apache ORC JUnit5 migration is finished.
### How was this patch tested?
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892366424
It's `findbags` failures on the existing code.
```
[INFO] --- findbugs-maven-plugin:3.0.5:check (analyze-compile) @ orc-core ---
[INFO] BugInstance size is 2
[INFO] Error size is 0
[INFO] Total bugs: 2
[INFO] Comparison of String parameter using == or != in org.apache.orc.TestUnicode.testUtf8(String, int, boolean) [org.apache.orc.TestUnicode] At TestUnicode.java:[line 77] ES_COMPARING_PARAMETER_STRING_WITH_EQ
[INFO] Call to equals(null) in org.apache.orc.impl.TestStreamName.test1() [org.apache.orc.impl.TestStreamName] At TestStreamName.java:[line 41] EC_NULL_ARG
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892383237
cc @williamhyun and @pgaref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892500692
Could you review this too, please, @pgaref ?
I know that this is a heavy PR, but most changes are straightforward replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892798611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #813:
URL: https://github.com/apache/orc/pull/813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892871373
Thank you so much, @williamhyun . Ya, I know that this is too big and tedious PR. :)
Merged to main/1.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892386046
This is the final piece of JUnit5 migration for 1.7.0 release. I hope `main` and `branch-1.7` similarly because this is a big change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892875617
This is backported to branch-1.7 with #809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892798611
Could you review this please, @williamhyun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892871373
Thank you so much, @williamhyun . Ya, I know that this is too big and tedious PR. :)
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #813:
URL: https://github.com/apache/orc/pull/813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892366424
It's `findbags` failures.
```
[INFO] --- findbugs-maven-plugin:3.0.5:check (analyze-compile) @ orc-core ---
[INFO] BugInstance size is 2
[INFO] Error size is 0
[INFO] Total bugs: 2
[INFO] Comparison of String parameter using == or != in org.apache.orc.TestUnicode.testUtf8(String, int, boolean) [org.apache.orc.TestUnicode] At TestUnicode.java:[line 77] ES_COMPARING_PARAMETER_STRING_WITH_EQ
[INFO] Call to equals(null) in org.apache.orc.impl.TestStreamName.test1() [org.apache.orc.impl.TestStreamName] At TestStreamName.java:[line 41] EC_NULL_ARG
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #813:
URL: https://github.com/apache/orc/pull/813#discussion_r682277668
##########
File path: java/pom.xml
##########
@@ -779,28 +779,22 @@
<version>5.7.0</version>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.junit.jupiter</groupId>
- <artifactId>junit-jupiter-engine</artifactId>
- <version>5.7.0</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-params</artifactId>
<version>5.7.0</version>
<scope>test</scope>
</dependency>
<dependency>
- <groupId>org.junit.vintage</groupId>
- <artifactId>junit-vintage-engine</artifactId>
- <version>5.7.2</version>
Review comment:
This is the last PR to remove `vintage` engine completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892386046
This is the final piece of JUnit5 migration for 1.7.0 release. I hope to keep `main` and `branch-1.7` similarly because this is a big change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun edited a comment on pull request #813: ORC-907: Remove junit-vintage-engine from core module
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #813:
URL: https://github.com/apache/orc/pull/813#issuecomment-892871373
Thank you so much, @williamhyun . Ya, I know that this is too big and tedious PR. :)
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org