You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/01/03 14:18:53 UTC

Re: Review Request 52382: Added stubs for OCI store.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52382/
-----------------------------------------------------------

(Updated Jan. 3, 2017, 10:18 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added stubs for OCI store.


Diffs (updated)
-----

  src/CMakeLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84 
  src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
  src/slave/containerizer/mesos/provisioner/oci/store.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/52382/diff/


Testing
-------


Thanks,

Qian Zhang

Re: Review Request 52382: Added stubs for OCI store.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52382/#review160878
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Jan. 8, 2017, 11:32 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52382/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2017, 11:32 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added stubs for OCI store.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84 
>   src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
>   src/slave/containerizer/mesos/provisioner/oci/store.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52382/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52382: Added stubs for OCI store.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52382/#review164298
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Feb. 1, 2017, 1:17 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52382/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 1:17 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added stubs for OCI store.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 09ef1aee680c6b91476092dbf61d4ca3a8d256bb 
>   src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
>   src/slave/containerizer/mesos/provisioner/oci/store.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52382/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52382: Added stubs for OCI store.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52382/
-----------------------------------------------------------

(Updated May 23, 2017, 9:17 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Fixed OCI store `using` format.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added stubs for OCI store.


Diffs (updated)
-----

  src/CMakeLists.txt ca7d538e2f7191c157e3e2237d56e3d75367f418 
  src/Makefile.am 7e4ce8532ec2c1b4216c2aa8d4262b2091e21c4a 
  src/slave/containerizer/mesos/provisioner/oci/store.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/52382/diff/10/

Changes: https://reviews.apache.org/r/52382/diff/9-10/


Testing
-------


Thanks,

Qian Zhang

Re: Review Request 52382: Added stubs for OCI store.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52382/
-----------------------------------------------------------

(Updated March 30, 2017, 9:42 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Addressed Jie's comments.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added stubs for OCI store.


Diffs (updated)
-----

  src/CMakeLists.txt b67b512cafd90558abf712a872310ab913fa38ae 
  src/Makefile.am 071656ad7354a802e8292140a7181cb70b68fe9e 
  src/slave/containerizer/mesos/provisioner/oci/store.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/52382/diff/9/

Changes: https://reviews.apache.org/r/52382/diff/8-9/


Testing
-------


Thanks,

Qian Zhang

Re: Review Request 52382: Added stubs for OCI store.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52382/#review164300
-----------------------------------------------------------




src/Makefile.am (line 951)
<https://reviews.apache.org/r/52382/#comment235987>

    Let's make sure the tailing `\` are aligned



src/Makefile.am (line 1091)
<https://reviews.apache.org/r/52382/#comment235988>

    Ditto.


- Jie Yu


On Feb. 1, 2017, 1:17 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52382/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 1:17 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-6681
>     https://issues.apache.org/jira/browse/MESOS-6681
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added stubs for OCI store.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 09ef1aee680c6b91476092dbf61d4ca3a8d256bb 
>   src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
>   src/slave/containerizer/mesos/provisioner/oci/store.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52382/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 52382: Added stubs for OCI store.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52382/
-----------------------------------------------------------

(Updated Feb. 1, 2017, 9:17 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added stubs for OCI store.


Diffs (updated)
-----

  src/CMakeLists.txt 09ef1aee680c6b91476092dbf61d4ca3a8d256bb 
  src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 
  src/slave/containerizer/mesos/provisioner/oci/store.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/52382/diff/


Testing
-------


Thanks,

Qian Zhang

Re: Review Request 52382: Added stubs for OCI store.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52382/
-----------------------------------------------------------

(Updated Jan. 9, 2017, 3:32 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-6681
    https://issues.apache.org/jira/browse/MESOS-6681


Repository: mesos


Description
-------

Added stubs for OCI store.


Diffs (updated)
-----

  src/CMakeLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84 
  src/Makefile.am 6d0f77be37af9bc4e22199418796d6d0c5b6c462 
  src/slave/containerizer/mesos/provisioner/oci/store.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/oci/store.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/52382/diff/


Testing
-------


Thanks,

Qian Zhang