You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Ralph Goers <ra...@dslextreme.com> on 2014/04/23 18:01:19 UTC
Re: svn commit: r1589432 - /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
Given that the index is checked for localParentsLength -1 under what circumstances will the buffer overflow?
Ralph
On Apr 23, 2014, at 7:47 AM, mattsicker@apache.org wrote:
> Author: mattsicker
> Date: Wed Apr 23 14:47:10 2014
> New Revision: 1589432
>
> URL: http://svn.apache.org/r1589432
> Log:
> Note a potential bug.
>
> Modified:
> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
>
> Modified: logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java?rev=1589432&r1=1589431&r2=1589432&view=diff
> ==============================================================================
> --- logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java (original)
> +++ logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java Wed Apr 23 14:47:10 2014
> @@ -155,6 +155,7 @@ public final class MarkerManager {
> if (index == localParentsLength - 1) {
> return false;
> }
> + // FIXME: buffer overflow
> markers[index++] = marker;
> }
> }
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
Re: svn commit: r1589432 - /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
Posted by Matt Sicker <bo...@gmail.com>.
I just noticed the line above. I thought that this was a problem late last
night and remembered to mark it today. I believe you're right, though, that
there won't be an ArrayIndexOutOfBoundsException. It would be good to
include that in the unit test (which I'll look at later).
On 23 April 2014 10:01, Ralph Goers <ra...@dslextreme.com> wrote:
> Given that the index is checked for localParentsLength -1 under what
> circumstances will the buffer overflow?
>
> Ralph
>
> On Apr 23, 2014, at 7:47 AM, mattsicker@apache.org wrote:
>
> > Author: mattsicker
> > Date: Wed Apr 23 14:47:10 2014
> > New Revision: 1589432
> >
> > URL: http://svn.apache.org/r1589432
> > Log:
> > Note a potential bug.
> >
> > Modified:
> >
> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
> >
> > Modified:
> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
> > URL:
> http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java?rev=1589432&r1=1589431&r2=1589432&view=diff
> >
> ==============================================================================
> > ---
> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
> (original)
> > +++
> logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/MarkerManager.java
> Wed Apr 23 14:47:10 2014
> > @@ -155,6 +155,7 @@ public final class MarkerManager {
> > if (index == localParentsLength - 1) {
> > return false;
> > }
> > + // FIXME: buffer overflow
> > markers[index++] = marker;
> > }
> > }
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
>
>
--
Matt Sicker <bo...@gmail.com>