[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #607: [MINOR] fix: allow `mountPoint` not containing '/'

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #607:
URL: https://github.com/apache/incubator-uniffle/pull/607#discussion_r1108136537


##########
storage/src/test/java/org/apache/uniffle/storage/common/DefaultStorageMediaProviderTest.java:
##########
@@ -40,4 +40,11 @@ public void testStorageProvider() {
     // invalid uri should also be reported as HDD
     assertEquals(StorageMedia.HDD, provider.getStorageMediaFor("file@xx:///path/to/a"));
   }
+
+  @Test
+  public void getGetDeviceName() {

Review Comment:
   how about mock the `getDeviceName` method?
   
   Seems it was declared as static, maybe an instance method is easier to be mocked?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org