[jira] [Commented] (CLOUDSTACK-9676) Start instance fails after reverting to a VM snapshot, when there are child VM snapshots

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747757#comment-15747757 ] 

ASF GitHub Bot commented on CLOUDSTACK-9676:
--------------------------------------------

GitHub user sateesh-chodapuneedi opened a pull request:

    https://github.com/apache/cloudstack/pull/1828

    CLOUDSTACK-9676 Start instance fails after reverting to a VM snapshot when there are child VM snapshots

    Jira
    ===
    CLOUDSTACK-9676 Start instance fails after reverting to a VM snapshot when there are child VM snapshots
    
    Issue
    ====
    Start instance fails after reverting to a VM snapshot, when there is 1 or more child VM snapshots in the snapshot tree of the VM.
    Per the code that detects the presence of a snapshot, we are checking for only current snapshot instead of checking presence of any snapshot in the snapshot tree.
    The failure to detect all snapshots means ACP reconfigures the VM in wrong way assuming there are no snapshots for the VM.
    This results in start failure.
    
    Fix
    ===
    Ensure correct detection of VM snapshots in the VM snapshot tree
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sateesh-chodapuneedi/cloudstack pr-cloudstack-9676

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1828.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1828
    
----
commit 34c85f5847dd4d3e55700e324bf695c60b8a4ca6
Author: Sateesh Chodapuneedi <sa...@accelerite.com>
Date:   2016-12-13T20:22:15Z

    CLOUDSTACK-9676 Start instance fails after reverting to a VM snapshot, when there are child VM snapshots
    
    Issue
    ====
    Start instance fails after reverting to a VM snapshot, when there is 1 or more child VM snapshots in the snapshot tree of the VM.
    Per the code that detects the presence of a snapshot, we are checking for only current snapshot instead of checking presence of any snapshot in the snapshot tree.
    The failure to detect all snapshots means ACP reconfigures the VM in wrong way assuming there are no snapshots for the VM.
    This results in start failure.
    
    Fix
    ===
    Ensure correct detection of VM snapshots in the VM snapshot tree
    
    Signed-off-by: Sateesh Chodapuneedi <sa...@accelerite.com>

----


> Start instance fails after reverting to a VM snapshot, when there are child VM snapshots
> ----------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9676
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9676
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: VMware
>    Affects Versions: 4.9.0.1
>         Environment: vSphere 5.5
> ACS master commit 17653a86fad67447a4f13e455e336694ad5c1735
>            Reporter: Sateesh Chodapuneedi
>            Assignee: Sateesh Chodapuneedi
>            Priority: Critical
>             Fix For: 4.10.0.0
>
>
> Start instance fails after reverting to a VM snapshot, when there is 1 or more child VM snapshots in the snapshot tree of the VM.
> Per the code that detects the presence of a snapshot, we are checking for only current snapshot instead of checking presence of any snapshot in the snapshot tree. The failure to detect all snapshots means ACP reconfigures the VM in wrong way assuming there are no snapshots for the VM. This results in start failure.
> {code:borderStyle=solid}
>      public boolean hasSnapshot() throws Exception {
>          VirtualMachineSnapshotInfo info = getSnapshotInfo();
>          if (info != null) {
>             return info.getCurrentSnapshot() != null;
>          }
>          return false;
>      }
> {code}
> Steps to reproduce
> ===============
> # Prepare setup with esxi5.5
> # Deploy a vm and create three snapshot i1,i2,i3.
> # Delete i2. and stop vm
> # Revert vm to i1
> # Delete i1
> # Start vm
> Start vm is failing with error,
> {noformat}
> StartCommand failed due to Exception: java.lang.RuntimeException Message: Invalid configuration for device '0'.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)