You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Bertrand Delacretaz (JIRA)" <ji...@apache.org> on 2008/02/18 09:50:35 UTC

[jira] Created: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Add a "currentNode" variable to the scripting context for all languages
-----------------------------------------------------------------------

                 Key: SLING-252
                 URL: https://issues.apache.org/jira/browse/SLING-252
             Project: Sling
          Issue Type: Improvement
            Reporter: Bertrand Delacretaz
            Priority: Minor


As discussed in http://markmail.org/message/vokst7wb4k322zdc

currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger reassigned SLING-252:
---------------------------------------

    Assignee: Felix Meschberger

> Add a "currentNode" variable to the scripting context for all languages
> -----------------------------------------------------------------------
>
>                 Key: SLING-252
>                 URL: https://issues.apache.org/jira/browse/SLING-252
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Bertrand Delacretaz
>            Assignee: Felix Meschberger
>            Priority: Minor
>
> As discussed in http://markmail.org/message/vokst7wb4k322zdc
> currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Posted by "Michael Marth (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570603#action_12570603 ] 

Michael Marth commented on SLING-252:
-------------------------------------

The 15 minutes Sling guide needs to be updated accordingly by someone with write rights.

> Add a "currentNode" variable to the scripting context for all languages
> -----------------------------------------------------------------------
>
>                 Key: SLING-252
>                 URL: https://issues.apache.org/jira/browse/SLING-252
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> As discussed in http://markmail.org/message/vokst7wb4k322zdc
> currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570638#action_12570638 ] 

Carsten Ziegeler commented on SLING-252:
----------------------------------------

And I think as we have "currentNode", we should remove resource.node.

> Add a "currentNode" variable to the scripting context for all languages
> -----------------------------------------------------------------------
>
>                 Key: SLING-252
>                 URL: https://issues.apache.org/jira/browse/SLING-252
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> As discussed in http://markmail.org/message/vokst7wb4k322zdc
> currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570609#action_12570609 ] 

bdelacretaz edited comment on SLING-252 at 2/20/08 12:58 AM:
---------------------------------------------------------------------

Ok, I'll update the 15 minutes thing when I find 15 minutes to do it ;-)

Note that resource.node still works as before in server-side javascript, currentNode is just a convenience.

      was (Author: bdelacretaz):
    Ok, I'll update the 15 minutes time when I find 15 minutes to do it ;-)

Note that resource.node still works as before in server-side javascript, currentNode is just a convenience.
  
> Add a "currentNode" variable to the scripting context for all languages
> -----------------------------------------------------------------------
>
>                 Key: SLING-252
>                 URL: https://issues.apache.org/jira/browse/SLING-252
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> As discussed in http://markmail.org/message/vokst7wb4k322zdc
> currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-252.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0

And the second step: rename the default JSP variable name for the current node to "currentNode" (was "node") in Rev. 628656.

Please close, if this ok for you. Thanks.

> Add a "currentNode" variable to the scripting context for all languages
> -----------------------------------------------------------------------
>
>                 Key: SLING-252
>                 URL: https://issues.apache.org/jira/browse/SLING-252
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>            Reporter: Bertrand Delacretaz
>            Assignee: Felix Meschberger
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> As discussed in http://markmail.org/message/vokst7wb4k322zdc
> currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570609#action_12570609 ] 

Bertrand Delacretaz commented on SLING-252:
-------------------------------------------

Ok, I'll update the 15 minutes time when I find 15 minutes to do it ;-)

Note that resource.node still works as before in server-side javascript, currentNode is just a convenience.

> Add a "currentNode" variable to the scripting context for all languages
> -----------------------------------------------------------------------
>
>                 Key: SLING-252
>                 URL: https://issues.apache.org/jira/browse/SLING-252
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> As discussed in http://markmail.org/message/vokst7wb4k322zdc
> currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570636#action_12570636 ] 

Felix Meschberger commented on SLING-252:
-----------------------------------------

> Note that resource.node still works as before in server-side javascript, currentNode is just a convenience.

In fact resource.node is also convenience and of the kind I don't like because it is JS only ;-)

> Add a "currentNode" variable to the scripting context for all languages
> -----------------------------------------------------------------------
>
>                 Key: SLING-252
>                 URL: https://issues.apache.org/jira/browse/SLING-252
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> As discussed in http://markmail.org/message/vokst7wb4k322zdc
> currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569812#action_12569812 ] 

Felix Meschberger commented on SLING-252:
-----------------------------------------

Thanks for creating the issue. I just committed a first step in Rev. 628655.

> Add a "currentNode" variable to the scripting context for all languages
> -----------------------------------------------------------------------
>
>                 Key: SLING-252
>                 URL: https://issues.apache.org/jira/browse/SLING-252
>             Project: Sling
>          Issue Type: Improvement
>            Reporter: Bertrand Delacretaz
>            Assignee: Felix Meschberger
>            Priority: Minor
>
> As discussed in http://markmail.org/message/vokst7wb4k322zdc
> currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertrand Delacretaz closed SLING-252.
-------------------------------------

    Assignee: Bertrand Delacretaz  (was: Felix Meschberger)

Integration tests added in revision 628666

> Add a "currentNode" variable to the scripting context for all languages
> -----------------------------------------------------------------------
>
>                 Key: SLING-252
>                 URL: https://issues.apache.org/jira/browse/SLING-252
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> As discussed in http://markmail.org/message/vokst7wb4k322zdc
> currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-252) Add a "currentNode" variable to the scripting context for all languages

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated SLING-252:
------------------------------------

    Component/s: Scripting

> Add a "currentNode" variable to the scripting context for all languages
> -----------------------------------------------------------------------
>
>                 Key: SLING-252
>                 URL: https://issues.apache.org/jira/browse/SLING-252
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>            Reporter: Bertrand Delacretaz
>            Assignee: Felix Meschberger
>            Priority: Minor
>
> As discussed in http://markmail.org/message/vokst7wb4k322zdc
> currentNode = Resource.adaptTo(Node.class), so the value is null if the Resource does not point to a Node

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.