You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Justin Erenkrantz <je...@ebuilt.com> on 2001/08/22 10:22:38 UTC
[PATCH] Properly install files with libtool.
I think we need to be doing this. But, I'm not enough of a libtool
hacker to be sure about this.
If we don't do this for a shared library build of httpd, we end up
copying libtool scripts over to our install location. Then, when
the scripts are first run, they copy over the actual binaries to
.libs/lt-*. What about when the user has blown away his source/build
directory after an install but before first execution? Oops.
So:
${prefix}/bin/httpd is a borne shell script from libtool.
${prefix}/bin/.libs/lt-httpd is the actual executable *only* copied at
first run.
This looks like it'd do the "right" thing, but I don't have time to test
it right now. I want to go to bed. -- justin
Index: rules.mk
===================================================================
RCS file: /home/cvs/httpd-2.0/build/rules.mk,v
retrieving revision 1.60
diff -u -r1.60 rules.mk
--- rules.mk 2001/08/21 23:41:35 1.60
+++ rules.mk 2001/08/22 08:11:10
@@ -90,7 +90,7 @@
# Helper programs
MKINSTALLDIRS = $(abs_srcdir)/build/mkdir.sh
-INSTALL = $(abs_srcdir)/build/install.sh -c
+INSTALL = $(LIBTOOL) --mode=install $(abs_srcdir)/build/install.sh -c
INSTALL_DATA = $(INSTALL) -m 644
INSTALL_PROGRAM = $(INSTALL) -m 755 $(INSTALL_PROG_FLAGS)
Re: [PATCH] Properly install files with libtool.
Posted by Greg Stein <gs...@lyra.org>.
Looks correct to me. Surprised it wasn't there already.
+1
Cheers,
-g
On Wed, Aug 22, 2001 at 01:22:38AM -0700, Justin Erenkrantz wrote:
> I think we need to be doing this. But, I'm not enough of a libtool
> hacker to be sure about this.
>
> If we don't do this for a shared library build of httpd, we end up
> copying libtool scripts over to our install location. Then, when
> the scripts are first run, they copy over the actual binaries to
> .libs/lt-*. What about when the user has blown away his source/build
> directory after an install but before first execution? Oops.
>
> So:
>
> ${prefix}/bin/httpd is a borne shell script from libtool.
> ${prefix}/bin/.libs/lt-httpd is the actual executable *only* copied at
> first run.
>
> This looks like it'd do the "right" thing, but I don't have time to test
> it right now. I want to go to bed. -- justin
>
> Index: rules.mk
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/build/rules.mk,v
> retrieving revision 1.60
> diff -u -r1.60 rules.mk
> --- rules.mk 2001/08/21 23:41:35 1.60
> +++ rules.mk 2001/08/22 08:11:10
> @@ -90,7 +90,7 @@
> # Helper programs
>
> MKINSTALLDIRS = $(abs_srcdir)/build/mkdir.sh
> -INSTALL = $(abs_srcdir)/build/install.sh -c
> +INSTALL = $(LIBTOOL) --mode=install $(abs_srcdir)/build/install.sh -c
> INSTALL_DATA = $(INSTALL) -m 644
> INSTALL_PROGRAM = $(INSTALL) -m 755 $(INSTALL_PROG_FLAGS)
>
--
Greg Stein, http://www.lyra.org/