You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Nick Wiedenbrueck (JIRA)" <ji...@apache.org> on 2010/10/19 17:12:28 UTC
[jira] Created: (WICKET-3119) Localizer cache does not include
style in cache key when no component is given
Localizer cache does not include style in cache key when no component is given
------------------------------------------------------------------------------
Key: WICKET-3119
URL: https://issues.apache.org/jira/browse/WICKET-3119
Project: Wicket
Issue Type: Bug
Components: wicket
Reporter: Nick Wiedenbrueck
Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles this leads to unexpected behavior.
I'll attach a patch with test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3119) Localizer cache does not include
style in cache key when no component is given
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3119.
-----------------------------------
Resolution: Invalid
Assignee: Igor Vaynberg
not sure what version of wicket you are using, but in 1.4.x and 1.5.x getcachekey() looks like this:
{code}
buffer.append("-").append(component.getLocale());
buffer.append("-").append(component.getStyle()); <=======
cacheKey = buffer.toString();
{code}
> Localizer cache does not include style in cache key when no component is given
> ------------------------------------------------------------------------------
>
> Key: WICKET-3119
> URL: https://issues.apache.org/jira/browse/WICKET-3119
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Nick Wiedenbrueck
> Assignee: Igor Vaynberg
> Attachments: localizer.patch
>
>
> Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
> When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3119) Localizer cache does not include
style in cache key when no component is given
Posted by "Nick Wiedenbrueck (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Wiedenbrueck updated WICKET-3119:
--------------------------------------
Attachment: localizer.patch
Patch with unit tests
> Localizer cache does not include style in cache key when no component is given
> ------------------------------------------------------------------------------
>
> Key: WICKET-3119
> URL: https://issues.apache.org/jira/browse/WICKET-3119
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Nick Wiedenbrueck
> Attachments: localizer.patch
>
>
> Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
> When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3119) Localizer cache does not include
style in cache key when no component is given
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923252#action_12923252 ]
Hudson commented on WICKET-3119:
--------------------------------
Integrated in Apache Wicket 1.4.x #219 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/219/])
> Localizer cache does not include style in cache key when no component is given
> ------------------------------------------------------------------------------
>
> Key: WICKET-3119
> URL: https://issues.apache.org/jira/browse/WICKET-3119
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Nick Wiedenbrueck
> Assignee: Igor Vaynberg
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: localizer.patch
>
>
> Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
> When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3119) Localizer cache does not include
style in cache key when no component is given
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3119.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M3
1.4.13
ahha. next time please provide a patch that applies cleanly.
> Localizer cache does not include style in cache key when no component is given
> ------------------------------------------------------------------------------
>
> Key: WICKET-3119
> URL: https://issues.apache.org/jira/browse/WICKET-3119
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Nick Wiedenbrueck
> Assignee: Igor Vaynberg
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: localizer.patch
>
>
> Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
> When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3119) Localizer cache does not include
style in cache key when no component is given
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923155#action_12923155 ]
Hudson commented on WICKET-3119:
--------------------------------
Integrated in Apache Wicket 1.5.x #427 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/427/])
Issue: WICKET-3119
> Localizer cache does not include style in cache key when no component is given
> ------------------------------------------------------------------------------
>
> Key: WICKET-3119
> URL: https://issues.apache.org/jira/browse/WICKET-3119
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Nick Wiedenbrueck
> Assignee: Igor Vaynberg
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: localizer.patch
>
>
> Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
> When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (WICKET-3119) Localizer cache does not include
style in cache key when no component is given
Posted by "Nick Wiedenbrueck (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Wiedenbrueck reopened WICKET-3119:
---------------------------------------
That's the code when a component is given. I meant the code when no component is given (a couple of lines below that):
{code}
else
{
// locale is guaranteed to be != null
cacheKey += "-" + locale.toString();
}
{code}
> Localizer cache does not include style in cache key when no component is given
> ------------------------------------------------------------------------------
>
> Key: WICKET-3119
> URL: https://issues.apache.org/jira/browse/WICKET-3119
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Nick Wiedenbrueck
> Assignee: Igor Vaynberg
> Attachments: localizer.patch
>
>
> Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
> When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3119) Localizer cache does not include
style in cache key when no component is given
Posted by "Nick Wiedenbrueck (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nick Wiedenbrueck updated WICKET-3119:
--------------------------------------
Description:
Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles, this leads to unexpected behavior.
I'll attach a patch with test cases.
was:
Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles this leads to unexpected behavior.
I'll attach a patch with test cases.
> Localizer cache does not include style in cache key when no component is given
> ------------------------------------------------------------------------------
>
> Key: WICKET-3119
> URL: https://issues.apache.org/jira/browse/WICKET-3119
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Nick Wiedenbrueck
>
> Localizer uses a cache internally to cache the results of getString() methods. The getCacheKey() method creates the key for the cache entries:
> getCacheKey(final String key, final Component component, final Locale locale, final String style, final String variation)
> When a null component is given, this method creates a cache key from the key param and the locale param, but does not include the style param. When switching between styles, this leads to unexpected behavior.
> I'll attach a patch with test cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.