You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2014/01/04 13:34:51 UTC

[jira] [Commented] (HADOOP-10204) ThrottledInputStream should #close() the underlying stream

    [ https://issues.apache.org/jira/browse/HADOOP-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862290#comment-13862290 ] 

Steve Loughran commented on HADOOP-10204:
-----------------------------------------

looking at the code, probably good idea to tag the constructor arg as {{@Nonnull}} and have the ctor raise the NPE if it is null, avoids having a check on the close(). That'll let you add a test too, to keep jenkins happy

> ThrottledInputStream should #close() the underlying stream 
> -----------------------------------------------------------
>
>                 Key: HADOOP-10204
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10204
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>         Environment: CDH 2.0.0-cdh4.5.0 (30821ec616ee7a21ee8447949b7c6208a8f1e7d8) 
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>         Attachments: HADOOP-10204-trunk.patch, HADOOP-10204.patch
>
>
> While working on HADOOP-10203 I've noticed that ThrottledInputStream (DistCP V2) does not override #close(). This can also leak connection.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)