You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/29 11:31:34 UTC

[GitHub] [flink-connector-redis] MartijnVisser commented on pull request #3: [FLINK-15571] Add Redis sink

MartijnVisser commented on PR #3:
URL: https://github.com/apache/flink-connector-redis/pull/3#issuecomment-1199173047

   @eskabetxe Thanks a lot for the PR! It might make more sense for @sazzad16 and/or @chayim to review, as they are more familiar with Redis. 
   
   If you rebase this PR, you should also get the CI build information so we can validate that it works as expected. 
   
   Last but not least: before we merge it, we should get the FLIP accepted. There's currently a draft FLIP open (see https://cwiki.apache.org/confluence/display/FLINK/FLIP-254%3A+Redis+Streams+Connector) and I'm waiting for feedback from @sazzad16 before we can bring it up for discussion and vote in the Dev mailing list. If you have any feedback on the FLIP, feel free to let me know too!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org