[GitHub] [any23] HansBrende commented on a change in pull request #165: ANY23-458 Improve extractor and writer information in Rover

[GitBox <gi...@apache.org>]

HansBrende commented on a change in pull request #165:
URL: https://github.com/apache/any23/pull/165#discussion_r528038021



##########
File path: cli/src/main/java/org/apache/any23/cli/Rover.java
##########
@@ -112,12 +117,16 @@ public String getIdentifier() {
     @Parameter(description = "input IRIs {<url>|<file>}+", converter = ArgumentToIRIConverter.class)
     protected List<String> inputIRIs = new LinkedList<>();
 
-    @Parameter(names = { "-e",
-            "--extractors" }, description = "a comma-separated list of extractors, e.g. rdf-xml,rdf-turtle")
-    private List<String> extractors = new LinkedList<>();
+    @Parameter(names = { "-e", "--extractors" }, description = "a comma-separated list of extractors, "
+            + "e.g. rdf-xml,rdf-turtle, etc. A complete extractor list can be obtained by calling ./any23 extractor --list")
+    private List<String> extractors = new LinkedList<String>() {
+        {
+            addAll(eRegistry.getAllNames());
+        }
+    };
 
     @Parameter(names = { "-f",
-            "--format" }, description = "a comma-separated list of writer factories, e.g. notrivial,nquads")
+            "--format" }, description = "a comma-separated list of writer factories, e.g. json,jsonld,nquads,notrivial,ntriples,trix,turtle,uri")

Review comment:
       @lewismc the --extractors improvement looks good, however the writer example won't work. The only reason `notrivial` can precede `nquads` is that `notrivial` is a delegating writer factory... i.e., it *pre-processes* the triples before passing them to the nquads writer factory.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org