You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "caicancai (via GitHub)" <gi...@apache.org> on 2024/01/09 15:59:40 UTC
[PR] docs: add sudo for install commands [arrow-datafusion]
caicancai opened a new pull request, #8804:
URL: https://github.com/apache/arrow-datafusion/pull/8804
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
add sudo for install commands
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add sudo for install commands [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #8804:
URL: https://github.com/apache/arrow-datafusion/pull/8804#discussion_r1447256304
##########
docs/source/contributor-guide/index.md:
##########
@@ -95,7 +95,7 @@ Compiling DataFusion from sources requires an installed version of the protobuf
On most platforms this can be installed from your system's package manager
```
-$ apt install -y protobuf-compiler
+$ sudo apt install -y protobuf-compiler
$ dnf install -y protobuf-devel
Review Comment:
Let's start with this change and we can always update the instructions later if we find something that could make it clearer
Thanks again @caicancai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add sudo for install commands [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #8804:
URL: https://github.com/apache/arrow-datafusion/pull/8804#issuecomment-1884867516
Thanks for the review, I will fix it together in the next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add sudo for install commands [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #8804:
URL: https://github.com/apache/arrow-datafusion/pull/8804#discussion_r1446551873
##########
docs/source/contributor-guide/index.md:
##########
@@ -95,7 +95,7 @@ Compiling DataFusion from sources requires an installed version of the protobuf
On most platforms this can be installed from your system's package manager
```
-$ apt install -y protobuf-compiler
+$ sudo apt install -y protobuf-compiler
$ dnf install -y protobuf-devel
Review Comment:
I wonder if we should add `sudo` to the other similar commands (like `dnf` and `pacman`) 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add sudo for install commands [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8804:
URL: https://github.com/apache/arrow-datafusion/pull/8804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add sudo for install commands [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #8804:
URL: https://github.com/apache/arrow-datafusion/pull/8804#discussion_r1446811176
##########
docs/source/contributor-guide/index.md:
##########
@@ -95,7 +95,7 @@ Compiling DataFusion from sources requires an installed version of the protobuf
On most platforms this can be installed from your system's package manager
```
-$ apt install -y protobuf-compiler
+$ sudo apt install -y protobuf-compiler
$ dnf install -y protobuf-devel
Review Comment:
I have tested it on my Linux machine. Pacman and dnf can be used without sudo.
But apt install -y protobuf-compiler seems to require sudo under ordinary users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add sudo for install commands [arrow-datafusion]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on code in PR #8804:
URL: https://github.com/apache/arrow-datafusion/pull/8804#discussion_r1446813906
##########
docs/source/contributor-guide/index.md:
##########
@@ -95,7 +95,7 @@ Compiling DataFusion from sources requires an installed version of the protobuf
On most platforms this can be installed from your system's package manager
```
-$ apt install -y protobuf-compiler
+$ sudo apt install -y protobuf-compiler
$ dnf install -y protobuf-devel
Review Comment:
But the dnf command also seems to require apt installation. Do you need to add something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org