You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "christophd (via GitHub)" <gi...@apache.org> on 2024/03/06 20:02:34 UTC
[PR] chore(lint): Use golangci-lint version matching go version 1.21 [camel-k]
christophd opened a new pull request, #5227:
URL: https://github.com/apache/camel-k/pull/5227
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(lint): Update golangci-lint version to 1.55 [camel-k]
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on PR #5227:
URL: https://github.com/apache/camel-k/pull/5227#issuecomment-1983030017
> @squakez ok, thanks: I rebased to main branch including your fix. IMO this PR is still valid as it updates golangci-lint to an even newer version 1.55 and fixes all new lint errors coming with this new version.
+1, switching from `assert.Nil(t, err)` to `require.NoError(t, err)` is very welcome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(lint): Update golangci-lint version to 1.55 [camel-k]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd merged PR #5227:
URL: https://github.com/apache/camel-k/pull/5227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(lint): Use golangci-lint version matching go version 1.21 [camel-k]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #5227:
URL: https://github.com/apache/camel-k/pull/5227#issuecomment-1982970085
@squakez ok, thanks: I rebased to main branch including your fix. IMO this PR is still valid as it updates golangci-lint to an even newer version 1.55 and fixes all new lint errors coming with this new version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org