You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/01/17 10:46:21 UTC
[GitHub] [incubator-apisix] membphis opened a new pull request #1077:
bugfix: updated the dns parse result by TTL.
membphis opened a new pull request #1077: bugfix: updated the dns parse result by TTL.
URL: https://github.com/apache/incubator-apisix/pull/1077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1077: bugfix: updated the dns parse result by TTL.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1077: bugfix: updated the dns parse result by TTL.
URL: https://github.com/apache/incubator-apisix/pull/1077#discussion_r368797771
##########
File path: t/core/lrucache.t
##########
@@ -204,3 +204,40 @@ release: {"_cache_ver":"t1","name":"aaa"}
obj: {"_cache_ver":"t2","name":"bbb"}
--- no_error_log
[error]
+
+
+
+=== TEST 6: invalid_stale = true
Review comment:
Yes, the DNS cache requires the parameter `invalid_stale = true`. It cannot reuse stale data first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1077: bugfix:
updated the dns parse result by TTL.
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1077: bugfix: updated the dns parse result by TTL.
URL: https://github.com/apache/incubator-apisix/pull/1077#issuecomment-575576040
Adding a test case is not easy because it depends on the special response of the DNS server.
For example: DNS query results need to include CNAME return.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1077: bugfix: updated the dns parse result by TTL.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1077: bugfix: updated the dns parse result by TTL.
URL: https://github.com/apache/incubator-apisix/pull/1077#discussion_r368797049
##########
File path: conf/config.yaml
##########
@@ -48,6 +48,7 @@ apisix:
- 223.5.5.5
- 1.1.1.1
- 8.8.8.8
+ dns_resolver_valid: 30 # valid time for dns result 30 seconds
Review comment:
https://github.com/apache/incubator-apisix/pull/1077#issue-364080437
I added some description right now, please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming merged pull request #1077: bugfix:
updated the dns parse result by TTL.
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1077: bugfix: updated the dns parse result by TTL.
URL: https://github.com/apache/incubator-apisix/pull/1077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1077: bugfix: updated the dns parse result by TTL.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1077: bugfix: updated the dns parse result by TTL.
URL: https://github.com/apache/incubator-apisix/pull/1077#discussion_r368788847
##########
File path: conf/config.yaml
##########
@@ -48,6 +48,7 @@ apisix:
- 223.5.5.5
- 1.1.1.1
- 8.8.8.8
+ dns_resolver_valid: 30 # valid time for dns result 30 seconds
Review comment:
I am not get your point why we need this PR, I think you should explain bug in PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1077: bugfix: updated the dns parse result by TTL.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1077: bugfix: updated the dns parse result by TTL.
URL: https://github.com/apache/incubator-apisix/pull/1077#discussion_r368788515
##########
File path: t/core/lrucache.t
##########
@@ -204,3 +204,40 @@ release: {"_cache_ver":"t1","name":"aaa"}
obj: {"_cache_ver":"t2","name":"bbb"}
--- no_error_log
[error]
+
+
+
+=== TEST 6: invalid_stale = true
Review comment:
Is this test case for DNS?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services