You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "yuzelin (via GitHub)" <gi...@apache.org> on 2025/07/24 07:40:41 UTC
[PR] [core] Batch tag supports custom time zone [paimon]
yuzelin opened a new pull request, #5954:
URL: https://github.com/apache/paimon/pull/5954
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Follow #5972
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Batch auto tag supports custom time zone [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #5954:
URL: https://github.com/apache/paimon/pull/5954#discussion_r2227784704
##########
paimon-core/src/main/java/org/apache/paimon/tag/TagBatchCreation.java:
##########
@@ -45,22 +45,24 @@ public class TagBatchCreation {
private final TagManager tagManager;
private final SnapshotManager snapshotManager;
private final TagDeletion tagDeletion;
+ private final ZoneId zoneId;
public TagBatchCreation(FileStoreTable table) {
this.table = table;
this.snapshotManager = table.snapshotManager();
this.tagManager = table.tagManager();
this.tagDeletion = table.store().newTagDeletion();
this.options = table.coreOptions();
+ this.zoneId = options.sinkProcessTimeZone();
}
public void createTag() {
Snapshot snapshot = snapshotManager.latestSnapshot();
if (snapshot == null) {
return;
}
- Instant instant = Instant.ofEpochMilli(snapshot.timeMillis());
- LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZoneId.systemDefault());
+ LocalDateTime localDateTime =
+ Instant.ofEpochMilli(snapshot.timeMillis()).atZone(zoneId).toLocalDateTime();
Review Comment:
Add a test for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Batch auto tag supports custom time zone [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #5954:
URL: https://github.com/apache/paimon/pull/5954#issuecomment-3117334397
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Batch auto tag supports custom time zone [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #5954:
URL: https://github.com/apache/paimon/pull/5954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org