You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/08/30 11:42:43 UTC

[GitHub] [incubator-linkis] peacewong commented on a diff in pull request #3129: [linkis-gateway-server-support] Modification of scala file floating red

peacewong commented on code in PR #3129:
URL: https://github.com/apache/incubator-linkis/pull/3129#discussion_r958371121


##########
linkis-spring-cloud-services/linkis-service-gateway/linkis-gateway-server-support/src/main/scala/org/apache/linkis/gateway/ujes/route/EntranceGatewayRouter.scala:
##########
@@ -27,12 +27,14 @@ import org.apache.linkis.protocol.constants.TaskConstant
 
 import org.apache.commons.lang3.StringUtils
 
+import java.util.Locale
+
 class EntranceGatewayRouter extends AbstractGatewayRouter {
 
   protected def findEntranceService(parsedServiceId: String) = findService(
     parsedServiceId,
     list => {
-      val services = list.filter(_.toLowerCase.contains("entrance"))
+      val services = list.filter(_.toLowerCase(Locale.ROOT).contains("entrance"))

Review Comment:
   Is it better to modify it to Locale.getDefault



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org