[GitHub] [spark] MaxGekk commented on a change in pull request #26291: [SPARK-29629][SQL] Support typed integer literal expression

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #26291: [SPARK-29629][SQL] Support typed integer literal expression
URL: https://github.com/apache/spark/pull/26291#discussion_r339922837
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ##########
 @@ -1799,6 +1799,16 @@ class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
         case "X" =>
           val padding = if (value.length % 2 != 0) "0" else ""
           Literal(DatatypeConverter.parseHexBinary(padding + value))
+        case "INTEGER" =>
+          val i = try {
+            Integer.parseInt(value)
+          } catch {
+            case e: NumberFormatException =>
+              val ex = new ParseException(s"Cannot parse the Int value: $value, $e", ctx)
+              ex.setStackTrace(e.getStackTrace)
+              throw ex
+          }
+          Literal(i)
 
 Review comment:
   Could you replace it by `Literal(i, IntegerType)`, so, Literal.apply() doesn't have to pattern match `i` to infer `IntegerType`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org