You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/05/31 01:10:44 UTC
Review Request: Changed reaper to use Future as the notification mechanism.
The notification is now sent only if the pid is explicitly registered via
the monitor() call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11554/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
Rebased against master. Previous review received "shipit"s but got lost.
Diffs
-----
src/slave/cgroups_isolator.hpp 7b8270d0b0f94a71da12bc123d39b44c40c3f7ed
src/slave/cgroups_isolator.cpp 9b3a3a5dfec27a119fdd47a88f016e21470eb88d
src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190
src/slave/process_isolator.cpp d4f7b7603452e7226189899aca7e3c94e537829f
src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90
src/slave/reaper.cpp 1d826d1b5fe1048b03662a1e9d12b18371e5c88f
src/tests/reaper_tests.cpp fbb6066652c0f36c0a8fd9b0c4dac7e0240a5210
Diff: https://reviews.apache.org/r/11554/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request: Changed reaper to use Future as the notification
mechanism. The notification is now sent only if the pid is explicitly
registered via the monitor() call.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On May 31, 2013, 5:13 p.m., Vinod Kone wrote:
> > src/slave/cgroups_isolator.cpp, line 798
> > <https://reviews.apache.org/r/11554/diff/1/?file=299192#file299192line798>
> >
> > s/status/status of " << pid << " /
> >
> > Also, can we pull this down so that we can also include the executor and framework ids?
Fixed in https://reviews.apache.org/r/11556/
> On May 31, 2013, 5:13 p.m., Vinod Kone wrote:
> > src/slave/cgroups_isolator.cpp, line 802
> > <https://reviews.apache.org/r/11554/diff/1/?file=299192#file299192line802>
> >
> > ditto
Fixed in https://reviews.apache.org/r/11556/
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11554/#review21255
-----------------------------------------------------------
On May 31, 2013, 6:43 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11554/
> -----------------------------------------------------------
>
> (Updated May 31, 2013, 6:43 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> Rebased against master. Previous review received "shipit"s but got lost.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.hpp 7b8270d0b0f94a71da12bc123d39b44c40c3f7ed
> src/slave/cgroups_isolator.cpp 9b3a3a5dfec27a119fdd47a88f016e21470eb88d
> src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190
> src/slave/process_isolator.cpp d4f7b7603452e7226189899aca7e3c94e537829f
> src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90
> src/slave/reaper.cpp 1d826d1b5fe1048b03662a1e9d12b18371e5c88f
> src/tests/reaper_tests.cpp fbb6066652c0f36c0a8fd9b0c4dac7e0240a5210
>
> Diff: https://reviews.apache.org/r/11554/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Changed reaper to use Future as the notification
mechanism. The notification is now sent only if the pid is explicitly
registered via the monitor() call.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11554/#review21255
-----------------------------------------------------------
Ship it!
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/11554/#comment44125>
s/status/status of " << pid << " /
Also, can we pull this down so that we can also include the executor and framework ids?
src/slave/cgroups_isolator.cpp
<https://reviews.apache.org/r/11554/#comment44127>
ditto
src/slave/reaper.cpp
<https://reviews.apache.org/r/11554/#comment44129>
s/a/our/
src/slave/reaper.cpp
<https://reviews.apache.org/r/11554/#comment44130>
s/, then/; /
src/slave/reaper.cpp
<https://reviews.apache.org/r/11554/#comment44131>
s/process statuses/processes first/
src/slave/reaper.cpp
<https://reviews.apache.org/r/11554/#comment44132>
great comments!
- Vinod Kone
On May 30, 2013, 11:10 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11554/
> -----------------------------------------------------------
>
> (Updated May 30, 2013, 11:10 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> Rebased against master. Previous review received "shipit"s but got lost.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolator.hpp 7b8270d0b0f94a71da12bc123d39b44c40c3f7ed
> src/slave/cgroups_isolator.cpp 9b3a3a5dfec27a119fdd47a88f016e21470eb88d
> src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190
> src/slave/process_isolator.cpp d4f7b7603452e7226189899aca7e3c94e537829f
> src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90
> src/slave/reaper.cpp 1d826d1b5fe1048b03662a1e9d12b18371e5c88f
> src/tests/reaper_tests.cpp fbb6066652c0f36c0a8fd9b0c4dac7e0240a5210
>
> Diff: https://reviews.apache.org/r/11554/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Changed reaper to use Future as the notification
mechanism. The notification is now sent only if the pid is explicitly
registered via the monitor() call.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11554/
-----------------------------------------------------------
(Updated May 31, 2013, 6:43 p.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Addressed Vinod's comments.
Description
-------
Rebased against master. Previous review received "shipit"s but got lost.
Diffs (updated)
-----
src/slave/cgroups_isolator.hpp 7b8270d0b0f94a71da12bc123d39b44c40c3f7ed
src/slave/cgroups_isolator.cpp 9b3a3a5dfec27a119fdd47a88f016e21470eb88d
src/slave/process_isolator.hpp 9875f4a6e8e109e31ad390fbd7a84d03ad747190
src/slave/process_isolator.cpp d4f7b7603452e7226189899aca7e3c94e537829f
src/slave/reaper.hpp 09844d8d47b143ee369e0c82b19d65a774df4a90
src/slave/reaper.cpp 1d826d1b5fe1048b03662a1e9d12b18371e5c88f
src/tests/reaper_tests.cpp fbb6066652c0f36c0a8fd9b0c4dac7e0240a5210
Diff: https://reviews.apache.org/r/11554/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu