You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Claudenw (via GitHub)" <gi...@apache.org> on 2023/11/02 13:29:41 UTC
[PR] CASSANDRA-18969 - added missing copyrights [cassandra-java-driver]
Claudenw opened a new pull request, #1742:
URL: https://github.com/apache/cassandra-java-driver/pull/1742
added Christian Stein copyright notice
performing grep for `[Cc]opyright`, `(C)`, and `(c)` only uncovered the one copyright not listed in the Notice file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANDRA-18969 - added missing copyrights [4.x] [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce closed pull request #1742: CASSANDRA-18969 - added missing copyrights [4.x]
URL: https://github.com/apache/cassandra-java-driver/pull/1742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANDRA-18969 - added missing copyrights [4.x] [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1742:
URL: https://github.com/apache/cassandra-java-driver/pull/1742#issuecomment-1954950669
Closing based on quick conversation with @Claudenw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANDRA-18969 - added missing copyrights [cassandra-java-driver]
Posted by "Maxwell-Guo (via GitHub)" <gi...@apache.org>.
Maxwell-Guo commented on code in PR #1742:
URL: https://github.com/apache/cassandra-java-driver/pull/1742#discussion_r1380148838
##########
NOTICE.txt:
##########
@@ -17,4 +17,9 @@ see core/src/main/java/com/datastax/oss/driver/internal/core/type/util/VIntCodin
Guava
Copyright (C) 2007 The Guava Authors
This product includes software developed as part of the Guava project ( https://guava.dev ).
-see core/src/main/java/com/datastax/oss/driver/internal/core/util/CountingIterator.java
\ No newline at end of file
+see core/src/main/java/com/datastax/oss/driver/internal/core/util/CountingIterator.java
+
+(C) 2018 Christian Stein
+This product includes software developed by Christian Stein
+see ci/install-jdk.sh
+
Review Comment:
I think line 25 can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANDRA-18969 - added missing copyrights [cassandra-java-driver]
Posted by "Claudenw (via GitHub)" <gi...@apache.org>.
Claudenw commented on PR #1742:
URL: https://github.com/apache/cassandra-java-driver/pull/1742#issuecomment-1792259962
Removed the blank line as requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] CASSANDRA-18969 - added missing copyrights [4.x] [cassandra-java-driver]
Posted by "hhughes (via GitHub)" <gi...@apache.org>.
hhughes commented on PR #1742:
URL: https://github.com/apache/cassandra-java-driver/pull/1742#issuecomment-1813459417
Please close in favor of #1835 (which retains original contributor credit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org