[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3370: ARTEMIS-3021 OOM due to wrong CORE message memory estimation

[GitBox <gi...@apache.org>]

franz1981 edited a comment on pull request #3370:
URL: https://github.com/apache/activemq-artemis/pull/3370#issuecomment-740451251


   @gemmellr it seems that AMQP isn't affected by this because a pooled Netty (heap) buffer is used to encode stuff and then copy an exact sized byte[] where needed but I see another issue and is the pooled Netty heap buffer.
   That stealthy makes the broker memory footprint on heap much larger because Netty would create large byte[] arenas. I suggest to not use pooled heap buffer or it can stealthy cause OOM as well.
   This means either:
   - use off heap pooled Netty buffers to temporarily encode things 
   - use unpooled heap smartly sizes ones to save both the additional copy and pooling as a whole
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org