[jira] [Commented] (HDFS-8403) Eliminate retries in TestFileCreation#testOverwriteOpenForWrite

["Haohui Mai (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544416#comment-14544416 ] 

Haohui Mai commented on HDFS-8403:
----------------------------------

{code}
+  // Create a NN proxy without retries for testing.
+  public static final String  DFS_CLIENT_TEST_NO_PROXY_RETRIES = "dfs.client.test.no.proxy.retries";
+  public static final boolean DFS_CLIENT_TEST_NO_PROXY_RETRIES_DEFAULT = false;
{code}

We can either add {{VisibleForTesting}} annotation or some comments showing that it is only for testing thus we have no compatibility guarantees here, or going for a more fundamental fixes which requires removing the retries in NameNodeProxies  (or making the number of retries in nonHA case configurable).

Either approach looks good to me. +1 once is addressed.

> Eliminate retries in TestFileCreation#testOverwriteOpenForWrite
> ---------------------------------------------------------------
>
>                 Key: HDFS-8403
>                 URL: https://issues.apache.org/jira/browse/HDFS-8403
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: 2.7.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-8403.01.patch, HDFS-8403.02.patch
>
>
> TestFileCreation#testOverwriteOpenForWrite attempts 5 retries to verify the failure case.
> The retries are not necessary to verify correct behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)