[GitHub] [incubator-doris] imay commented on a change in pull request #1505: Add timediff function

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1505: Add timediff function
URL: https://github.com/apache/incubator-doris/pull/1505#discussion_r305179681
 
 

 ##########
 File path: be/src/runtime/result_writer.cpp
 ##########
 @@ -105,7 +105,8 @@ Status ResultWriter::add_one_row(TupleRow* row) {
             break;
 
         case TYPE_DATE:
-        case TYPE_DATETIME: {
+        case TYPE_DATETIME:
+        case TYPE_TIME: {
             char buf[64];
             const DateTimeValue* time_val = (const DateTimeValue*)(item);
 
 Review comment:
   I think use bigint to represent time in memory?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org