You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/21 15:17:33 UTC
[GitHub] [cordova-plugin-inappbrowser] MoemenMostafa opened a new pull
request #629: (ios) removing hard coded height
MoemenMostafa opened a new pull request #629: (ios) removing hard coded height
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/629
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
The hard coded height is causing a problem in phones with notch when this plugin used without the statusbar plugin.
https://github.com/apache/cordova-plugin-inappbrowser/issues/301
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on issue #629:
(ios) removing hard coded height
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on issue #629: (ios) removing hard coded height
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/629#issuecomment-589938615
We already have similar attempts for the status bar on devices with a notch: #546
But we want to remove this "fake statusbar" altogether soon #604
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org